Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure eeconfig initialised before reading EEPROM handedness. #17256

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

daskygit
Copy link
Member

Description

I noticed while using transient EEPROM and EE_HANDS that flashing using uf2-split-left, the left side matrix behaved as the right but the LEDs behaved correctly. This appears to be due to the eeconfig handedness being read before it's initialised returning 0.

I've added a check to split_pre_init to ensure eeconfig is enabled and initialise if not.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label May 30, 2022
@drashna drashna requested a review from a team May 31, 2022 07:03
@zvecr zvecr merged commit 62eaec5 into qmk:develop Jun 20, 2022
@daskygit daskygit deleted the fix/fake_ee_hands branch June 21, 2022 00:02
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants