Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pillow python dependency provided for NIX #17277

Closed
wants to merge 1 commit into from

Conversation

WonderBeat
Copy link

QMK requires pillow python dependency, but NIX project definition lacks of it

Description

Project requires python pillow and requirements.txt contains this dependency. But NIX project definition file doesn't.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label May 31, 2022
@sigprof
Copy link
Contributor

sigprof commented May 31, 2022

Already fixed by #17243 (and the fix is already in the master branch).

(Also changing just pyproject.toml is not enough — as a minimum, poetry.lock needs to be updated, and in this particular case more updates are needed to make things actually build properly, which you can find in that PR.)

@sigprof sigprof closed this May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants