Use --exclude-from=.gitignore in place of --exclude-standard #17399
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The lint check spews an error anytime it encounters a file that's listed in the output of
git_get_ignored_files
. However, the use of--exclude-standard
in the git shell command ran by the aforementioned python function also ignores files in.git/info/exclude
and the user's global.gitignore
.This has the undesirable consequence of always failing the lint check if the user added some of his keyboard or keymap folders in a personal git ignore file like
.git/info/exclude
or his global.gitignore
.As explained in the docstring of the function, the intent of the function is only to "return a list of files that would be captured by the current .gitignore". To actually achieve that and avoid false negatives, using the option
exclude-from=.gitignore
is more appropriate.Note:
exclude-from=.gitignore
works even when thecheck_dir
is not the root directoryTypes of Changes
Issues Fixed or Closed by This PR
Checklist