Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RGB heatmap skip NO_LED #17488

Merged
merged 1 commit into from
Jun 29, 2022
Merged

RGB heatmap skip NO_LED #17488

merged 1 commit into from
Jun 29, 2022

Conversation

daskygit
Copy link
Member

@daskygit daskygit commented Jun 27, 2022 •
edited by drashna
Loading

Description

As pointed out in PR #17184 I missed that a matrix position could be set to NO_LED. It now checks and skips any processing if the pressed or target position has NO_LED.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jun 27, 2022
@daskygit daskygit mentioned this pull request Jun 27, 2022
Merged
14 tasks
@daskygit daskygit requested a review from drashna June 27, 2022 21:51
@RagingCactus
Copy link
Contributor

Thanks for looking at my report and addressing it!

@drashna drashna requested a review from a team June 28, 2022 22:21
@drashna drashna merged commit dcdc729 into qmk:develop Jun 29, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@daskygit @zykrah
RGB Matrix Heatmap - Skip positions with NO_LED (qmk#17488)
162382c
@daskygit daskygit deleted the fix/rgb_heatmap_skip_noled branch September 12, 2022 13:57
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@daskygit @nolanseaton
RGB Matrix Heatmap - Skip positions with NO_LED (qmk#17488)
b7712f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daskygit @RagingCactus @drashna @fauxpark