Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Make debounce algorithms signal matrix changes #17554

Merged
merged 1 commit into from
Jul 7, 2022
Merged

[Core] Make debounce algorithms signal matrix changes #17554

merged 1 commit into from
Jul 7, 2022

Conversation

KarlK90
Copy link
Member

@KarlK90 KarlK90 commented Jul 3, 2022 •
edited
Loading

Description

In preparation of optimizing the matrix_task() to not do the matrix comparison twice but instead use the already known matrix state.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@KarlK90 KarlK90 requested review from zvecr and a team July 3, 2022 20:44
@KarlK90 KarlK90 changed the title [Core] Make debounce algorithmns signal matrix changes [Core] Make debounce algorithms signal matrix changes Jul 3, 2022
drashna
drashna approved these changes Jul 3, 2022
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to cause problems, at least.

@drashna drashna requested a review from a team July 3, 2022 21:24
@KarlK90 KarlK90 merged commit 8224f62 into qmk:develop Jul 7, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@KarlK90 @nolanseaton
Make debounce() signal changes in the cooked matrix as return value (q…
5a2ae53 
…mk#17554)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
core documentation translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KarlK90 @drashna