Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix POINTING_DEVICE_GESTURES_SCROLL_ENABLE typo #17850

Merged
merged 2 commits into from
Jul 31, 2022
Merged

Fix POINTING_DEVICE_GESTURES_SCROLL_ENABLE typo #17850

merged 2 commits into from
Jul 31, 2022

Conversation

dkao
Copy link
Contributor

@dkao dkao commented Jul 30, 2022

Description

POINTING_DEVICE_GESTURES_SCROLL_ENABLE in documentation, POINTING_DEVICE_GESTURE_SCROLL_ENABLE in code. Change code to the former to be consistent with the other configuration under POINTING_DEVICE_GESTURES_*.
Also slightly reword the documentation about POINTING_DEVICE_GESTURES_CURSOR_GLIDE_ENABLE.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

dkao added 2 commits July 30, 2022 01:22
@dkao
Fix typo for POINTING_DEVICE_GESTURES_SCROLL_ENABLE
2df152c 
Follow the name written in documentation which follows
POINTING_DEVICE_GESTURES_CURSOR_GLIDE_ENABLE
@dkao
Reword the blurb about POINTING_DEVICE_GESTURES_CURSOR_GLIDE_ENABLE i…
401e8a9 
…n docs
@drashna drashna requested a review from a team July 30, 2022 20:44
@zvecr zvecr merged commit b03a7ce into qmk:develop Jul 31, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@dkao @nolanseaton
Fix POINTING_DEVICE_GESTURES_SCROLL_ENABLE typo (qmk#17850)
c35fb72 
* Fix typo for POINTING_DEVICE_GESTURES_SCROLL_ENABLE

Follow the name written in documentation which follows
POINTING_DEVICE_GESTURES_CURSOR_GLIDE_ENABLE

* Reword the blurb about POINTING_DEVICE_GESTURES_CURSOR_GLIDE_ENABLE in docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dkao @drashna @fauxpark @zvecr