Prevent tap dance from wiping dynamic macros #17880
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces the userspace function
dynamic_macro_valid_key_user
to allow the user to omit certain events from being stored in the dynamic macros. This is particularly important whenDYN_*
keycodes are mapped to tap-dance keys; prior to these changes,DYN_*
keys (e.g.DYN_REC_START*
andDYN_REC_STOP
are triggered upon executing the macro (sinceTD(DYN)
records are stored in the buffer), leading to the bug where recorded macros can only be executed once before they are wiped.An example keymap implemented using this function is available here.
Types of Changes
Issues Fixed or Closed by This PR
Checklist