Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent tap dance from wiping dynamic macros #17880

Merged
merged 2 commits into from
Oct 3, 2022

Conversation

jasonkena
Copy link
Contributor

Description

This pull request introduces the userspace function dynamic_macro_valid_key_user to allow the user to omit certain events from being stored in the dynamic macros. This is particularly important when DYN_* keycodes are mapped to tap-dance keys; prior to these changes, DYN_* keys (e.g. DYN_REC_START* and DYN_REC_STOP are triggered upon executing the macro (since TD(DYN) records are stored in the buffer), leading to the bug where recorded macros can only be executed once before they are wiped.

An example keymap implemented using this function is available here.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Aug 2, 2022
@zvecr zvecr changed the base branch from master to develop August 2, 2022 22:34
@jasonkena jasonkena requested a review from drashna August 3, 2022 20:26
@drashna drashna requested a review from a team August 6, 2022 02:43
@tzarc tzarc merged commit c0e6a28 into qmk:develop Oct 3, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants