-
-
Notifications
You must be signed in to change notification settings - Fork 39.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add system76/launch_1
keyboard features
#17916
Conversation
a39362d
to
59e4eff
Compare
Thank you for your contribution! |
@jecassis , I think that you only need to rebase this PR with master and that should take care of the conflicts. |
ff41346
to
6ff4a2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently I forgot to click “Submit review” at the end, so my comment was left pending here for several months 🤦♂️
Thank you for your contribution! |
This PR has been ready to merge for a long while. All of the requested changes are implemented. Just waiting for final maintainer approval. @drashna can you please take a look and advise on how to proceed? |
Thank you for your contribution! |
Thank you for your contribution! |
Description
Implements the following changes for System76's Launch keyboard (launch_1):
LOCKING_SUPPORT_ENABLE
) and switch state consistency with keyboard LED state (LOCKING_RESYNC_ENABLE
) by default.TOTAL_EEPROM_BYTE_COUNT
from AVR library for total size for portability.EECONFIG_SIZE
(mirrors how VIA does the same).clang-format
).Types of Changes
Issues Fixed or Closed by this PR
Checklist