Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system76/launch_1 keyboard features #17916

Closed
wants to merge 20 commits into from

Conversation

jecassis
Copy link

@jecassis jecassis commented Aug 5, 2022

Description

Implements the following changes for System76's Launch keyboard (launch_1):

  • Disable mechanical locking support (LOCKING_SUPPORT_ENABLE) and switch state consistency with keyboard LED state (LOCKING_RESYNC_ENABLE) by default.
  • Use TOTAL_EEPROM_BYTE_COUNT from AVR library for total size for portability.
  • Start custom EEPROM region using EECONFIG_SIZE (mirrors how VIA does the same).
  • Add README for default keymap.
  • Remove custom Bootmagic Lite function and enable QMK's implementation in the Makefile.
  • Update comments on almost all keyboard and keymap files.
  • Allow removing System76 EC (i.e., configurator) functionality through a Makefile option (still enabled by default).
  • Add header file for System76 EC to ease sharing between various System76 keyboards.
  • Add key combination to unlock the keyboard and flash via System76 Firmware Updater (independent of QMK bootloader features).
  • Update USB "multiplexer" and document code behavior in substantial detail. Check changes for consistency with the USB Type-C Port Controller Interface Specification.
  • Enable removal of custom RGB matrix effects for space-saving (as implemented in Allow disabling RGB_MATRIX_ANIMATIONS on system76 keyboards with a pre-procesor directive #17478).
  • Correct a couple of minor comment typos in core QMK files.
  • Integrate and format changes from Move keyboard USB IDs and strings to data driven: S #17889 and Refactor legacy quantum keycodes in default-ish keymaps #17037.
  • Update C formatting (using clang-format).
  • Update copyright year.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by this PR

  • None

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team August 7, 2022 09:28
keyboards/system76/launch_1/rules.mk Outdated Show resolved Hide resolved
keyboards/system76/launch_1/rules.mk Outdated Show resolved Hide resolved
keyboards/system76/launch_1/rules.mk Show resolved Hide resolved
@PeterFalken
Copy link
Contributor

@jecassis, FYI PR #17478 was merged recently.

@jecassis jecassis requested a review from fauxpark August 19, 2022 12:47
@github-actions
Copy link

github-actions bot commented Oct 7, 2022

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 7, 2022
@PeterFalken
Copy link
Contributor

@jecassis , I think that you only need to rebase this PR with master and that should take care of the conflicts.

@github-actions github-actions bot removed python core translation via Adds via keymap and/or updates keyboard for via support CI documentation stale Issues or pull requests that have become inactive without resolution. labels Dec 12, 2022
@jecassis jecassis requested review from drashna and fauxpark and removed request for fauxpark and drashna January 25, 2023 21:18
@drashna drashna self-requested a review January 27, 2023 21:15
Copy link
Contributor

@sigprof sigprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently I forgot to click “Submit review” at the end, so my comment was left pending here for several months 🤦‍♂️

keyboards/system76/launch_1/config.h Outdated Show resolved Hide resolved
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Mar 17, 2023
@jecassis
Copy link
Author

jecassis commented Apr 3, 2023

This PR has been ready to merge for a long while. All of the requested changes are implemented. Just waiting for final maintainer approval. @drashna can you please take a look and advise on how to proceed?

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Apr 4, 2023
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label May 23, 2023
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants