Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle EEPROM reset keycode #18244

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Conversation

drashna
Copy link
Member

@drashna drashna commented Sep 1, 2022

Description

Slight change to QK_CLEAR_EEPROM, so that it's more in line with other eeprom related code. Specifically "disable" eeprom (set the eeprom disabled bit), so that on next init, eeprom is re-initialized.

Types of Changes

  • Core
  • Enhancement/optimization

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team September 1, 2022 22:34
@github-actions github-actions bot added the core label Sep 1, 2022
@drashna drashna merged commit 423826a into qmk:develop Sep 2, 2022
@drashna drashna deleted the keycode/eeprom_reset branch September 2, 2022 03:43
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants