Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UNICODE_KEY_OSX and UC_OSX #18290

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Remove UNICODE_KEY_OSX and UC_OSX #18290

merged 1 commit into from
Sep 6, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Sep 6, 2022

Description

It appears to have been over two years since these were deprecated. Time to rip it out.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team September 6, 2022 16:01
@spidey3 spidey3 requested a review from a team September 6, 2022 17:02
@zvecr zvecr merged commit 8833b28 into qmk:develop Sep 6, 2022
@fauxpark fauxpark deleted the unicode-remove-osx branch September 6, 2022 17:14
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@fauxpark @ramonimbao
Remove UNICODE_KEY_OSX and UC_OSX (qmk#18290)
68bc2a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spidey3 spidey3 spidey3 approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core documentation enhancement keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @zvecr @spidey3