Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling Pointing Device support in register code functions #18363

Merged
merged 6 commits into from
Sep 27, 2022
Merged

Enabling Pointing Device support in register code functions #18363

merged 6 commits into from
Sep 27, 2022

Conversation

drashna
Copy link
Member

@drashna drashna commented Sep 14, 2022

Description

Removes custom keycode handling for pointing device keyboards, and allows for register_code to properly handle mouse buttons when mousekeys is off.

Types of Changes

  • Core
  • Enhancement/optimization

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team September 14, 2022 18:22
@drashna drashna requested a review from a team September 17, 2022 17:30
@drashna drashna changed the title Pointing/register handling Enabling Pointing Device support in register code functions Sep 17, 2022
@drashna drashna merged commit fb400f2 into qmk:develop Sep 27, 2022
@drashna drashna deleted the pointing/register_handling branch September 27, 2022 03:49
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@drashna @ramonimbao
Enabling Pointing Device support in register code functions (qmk#18363)
9c5390e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drashna @fauxpark