Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Bluetooth API #18366

Merged
merged 3 commits into from
Sep 29, 2022
Merged

Start Bluetooth API #18366

merged 3 commits into from
Sep 29, 2022

Conversation

fauxpark
Copy link
Member

Description

This is pretty barebones for the moment, and I'm not entirely sure whether this implementation or a more RGB Matrix-esque driver model is better. At the very least it abstracts away the existing driver-specific function calls in keyboard.c and host.c.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team September 14, 2022 23:51
@fauxpark fauxpark marked this pull request as draft September 14, 2022 23:51
@zvecr
Copy link
Member

zvecr commented Sep 19, 2022

At the very least it abstracts away the existing driver-specific function calls in keyboard.c and host.c

Thats a decent enough iteration in my book. Having all the existing fragmentation removed from host/keyboard helps with some of the refactoring ive got staged.

@fauxpark fauxpark marked this pull request as ready for review September 20, 2022 07:24
@zvecr zvecr merged commit f80058d into qmk:develop Sep 29, 2022
@fauxpark fauxpark deleted the bluetooth-api branch September 29, 2022 19:17
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
naoki-mizuno added a commit to naoki-mizuno/qmk_firmware that referenced this pull request Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants