Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QP] Add RGB565 surface. Docs clarification, cleanup, tabsification, and reordering. #18396

Merged
merged 9 commits into from
Sep 18, 2022
Merged

[QP] Add RGB565 surface. Docs clarification, cleanup, tabsification, and reordering. #18396

merged 9 commits into from
Sep 18, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Sep 18, 2022

Description

Adds support for an RGB565 surface, aka framebuffer. Allows for drawing to RAM, then copying just the dirty region to another display.

Slight tweak to the image/font loader functions to allow for alternate methods of loading assets, with the filesystem stuff in the pipeline.

Also did documentation cleanup requested by Dasky.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team September 18, 2022 05:48
@tzarc tzarc requested a review from daskygit September 18, 2022 05:48
daskygit
daskygit reviewed Sep 18, 2022
View reviewed changes
Copy link
Member

@daskygit daskygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work well, good speed improvement even if I can't full size surface in memory.

The docs seem much simpler to digest in this format too, ta muchly.

docs/quantum_painter.md Show resolved Hide resolved
drivers/painter/generic/qp_rgb565_surface.c Outdated Show resolved Hide resolved
drivers/painter/generic/qp_rgb565_surface.h Outdated Show resolved Hide resolved
@tzarc tzarc requested review from daskygit and a team September 18, 2022 12:14
KarlK90
KarlK90 approved these changes Sep 18, 2022
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Only have some nits otherwise LGTM.

drivers/painter/generic/qp_rgb565_surface.c Outdated Show resolved Hide resolved
drivers/painter/generic/qp_rgb565_surface.c Outdated Show resolved Hide resolved
@tzarc tzarc merged commit 1849897 into qmk:develop Sep 18, 2022
@tzarc tzarc deleted the qp_updates branch September 18, 2022 21:30
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@tzarc @ramonimbao
[QP] Add RGB565 surface. Docs clarification, cleanup, tabsification, …
0256742 
…and reordering. (qmk#18396)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daskygit daskygit daskygit approved these changes

@KarlK90 KarlK90 KarlK90 approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzarc @KarlK90 @daskygit