Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Stabilize RP2040 Half-duplex PIO split comms take 2 #18421

Merged
merged 1 commit into from
Sep 20, 2022
Merged

[Core] Stabilize RP2040 Half-duplex PIO split comms take 2 #18421

merged 1 commit into from
Sep 20, 2022

Conversation

KarlK90
Copy link
Member

@KarlK90 KarlK90 commented Sep 19, 2022 •
edited
Loading

Description

...by moving the actually timing critical enter_rx_state() and leave_rx_state() functions to RAM in order to not be affected by XIP cache spikes. This commit also reverts the hacky USB interrupt disabling that was done in 293c53d

Tested successfully with RP2040 BastardKB half-duplex split.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@KarlK90
Stabilize Half-duplex PIO split comms take 2
858efa0 
...by moving the actually timing critical `enter_rx_state()` and
`leave_rx_state()` functions to RAM in order to not be affected by XIP
cache spikes. This commit also reverts the hacky USB interrupt disabling
that was done in 293c53d
@github-actions github-actions bot added the core label Sep 19, 2022
@KarlK90 KarlK90 requested a review from a team September 19, 2022 15:46
@zvecr zvecr requested a review from a team September 19, 2022 22:25
@KarlK90 KarlK90 merged commit 881aab9 into qmk:develop Sep 20, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@KarlK90 @ramonimbao
Stabilize Half-duplex PIO split comms take 2 (qmk#18421)
a142baa 
...by moving the actually timing critical `enter_rx_state()` and
`leave_rx_state()` functions to RAM in order to not be affected by XIP
cache spikes. This commit also reverts the hacky USB interrupt disabling
that was done in 293c53d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KarlK90 @zvecr