Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Keyboard Handwired alcor dactyl #18586

Merged
merged 13 commits into from
Nov 13, 2022
Merged

Adds Keyboard Handwired alcor dactyl #18586

merged 13 commits into from
Nov 13, 2022

Conversation

rocketstrong600
Copy link
Contributor

@rocketstrong600 rocketstrong600 commented Oct 4, 2022 •
edited
Loading

Description

Adds a new handwired keyboard alcor_dactyl that is a 5x7 Dactyl Manuform keyboard using a rp2040-zero

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr
zvecr previously approved these changes Oct 4, 2022
View reviewed changes
keyboards/handwired/alcor_dactyl/info.json Outdated Show resolved Hide resolved
keyboards/handwired/alcor_dactyl/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/alcor_dactyl/keymaps/default/keymap.c Show resolved Hide resolved
keyboards/handwired/alcor_dactyl/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/alcor_dactyl/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/alcor_dactyl/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/alcor_dactyl/rules.mk Outdated Show resolved Hide resolved
@zvecr zvecr dismissed their stale review October 4, 2022 15:37

wrong button

@rocketstrong600
Copy link
Contributor Author

rocketstrong600 commented Oct 4, 2022 •
edited
Loading

Thanks for looking at it. I just cleaned it up with your suggestions.

@rocketstrong600
Copy link
Contributor Author

looks so much neater side by side

@rocketstrong600 rocketstrong600 marked this pull request as draft October 9, 2022 15:09
@rocketstrong600 rocketstrong600 marked this pull request as ready for review October 21, 2022 15:26
@rocketstrong600 rocketstrong600 requested a review from zvecr October 28, 2022 09:21
@drashna drashna requested a review from a team November 8, 2022 04:48
@rocketstrong600 @fauxpark
Update keyboards/handwired/alcor_dactyl/readme.md
9b75b84 
Co-authored-by: Ryan <fauxpark@gmail.com>
@rocketstrong600 rocketstrong600 requested review from fauxpark and removed request for zvecr November 8, 2022 22:48
@drashna drashna merged commit cd682ad into qmk:master Nov 13, 2022
thystips pushed a commit to thystips/qmk_firmware that referenced this pull request Nov 24, 2022
@rocketstrong600 @fauxpark @thystips
[Keyboard] Add Handwired alcor dactyl (qmk#18586)
3352250 
Co-authored-by: Ryan <fauxpark@gmail.com>
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@rocketstrong600 @fauxpark @ramonimbao
[Keyboard] Add Handwired alcor dactyl (qmk#18586)
0aac61c 
Co-authored-by: Ryan <fauxpark@gmail.com>
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@rocketstrong600 @fauxpark @elpekenin
[Keyboard] Add Handwired alcor dactyl (qmk#18586)
d27cd0b 
Co-authored-by: Ryan <fauxpark@gmail.com>
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@rocketstrong600 @fauxpark @crembz
[Keyboard] Add Handwired alcor dactyl (qmk#18586)
5751e5a 
Co-authored-by: Ryan <fauxpark@gmail.com>
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@rocketstrong600 @fauxpark @nolanseaton
[Keyboard] Add Handwired alcor dactyl (qmk#18586)
2a29fc8 
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr zvecr left review comments

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rocketstrong600 @drashna @fauxpark @zvecr