Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI] Ensure consistent clean behaviour #18781

Merged
merged 2 commits into from
Oct 20, 2022
Merged

[CLI] Ensure consistent clean behaviour #18781

merged 2 commits into from
Oct 20, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 20, 2022 •
edited
Loading

Description

  • Converters by environment (-e CONVERT_TO=kb2040) did not clean
  • keymap.json (in or out of tree) ignored clean flag
    • also didnt incremental build either

Also minor alignment of flash code flow to make maintenance a little easier

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command python labels Oct 20, 2022
@zvecr zvecr changed the title Ensure consistent clean behaviour [CLI] Ensure consistent clean behaviour Oct 20, 2022
@zvecr zvecr requested a review from a team October 20, 2022 01:02
@zvecr zvecr merged commit 0b41c13 into qmk:develop Oct 20, 2022
@zvecr zvecr deleted the feature/clean_fixes branch November 23, 2022 19:35
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@zvecr @ramonimbao
[CLI] Ensure consistent clean behaviour (qmk#18781)
10f3f5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @fauxpark