Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWStudio MW65 Black Refactor #18824

Merged
merged 6 commits into from
Oct 23, 2022
Merged

MWStudio MW65 Black Refactor #18824

merged 6 commits into from
Oct 23, 2022

Conversation

noroadsleft
Copy link
Member

Description

  • refactor matrix definition (fill in blank spaces)
    I'm not convinced it's accurate, given the fact that the electrical definition was partially blank. I've gone for a "leave it the same as the existing implementation" solution given that I don't have access to this hardware.
  • rename LAYOUT to LAYOUT_65_ansi_blocker
  • add LAYOUT_65_ansi_blocker_tsangan
  • update maintainer value in info.json

cc @TW59420 (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 23, 2022
@noroadsleft noroadsleft requested a review from a team October 23, 2022 04:48
@zvecr zvecr merged commit 51dd63c into qmk:master Oct 23, 2022
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Oct 23, 2022
@noroadsleft @tacahiroy
MWStudio MW65 Black Refactor (qmk#18824)
ea25a63 
* mw65_black.h: add matrix diagram

* mw65_black.h: fill-in matrix definition

Fill the empty electrical positions with `KC_NO`.

* mw65_black.h: update matrix diagram

* rename LAYOUT to LAYOUT_65_ansi_blocker

* add LAYOUT_65_ansi_blocker_tsangan

* info.json: correct maintainer value
@noroadsleft noroadsleft deleted the rf/mwstudio_mw65_black branch October 23, 2022 20:03
hirakiuc pushed a commit to hirakiuc/qmk_firmware that referenced this pull request Oct 29, 2022
@noroadsleft @hirakiuc
MWStudio MW65 Black Refactor (qmk#18824)
7d00ab4 
* mw65_black.h: add matrix diagram

* mw65_black.h: fill-in matrix definition

Fill the empty electrical positions with `KC_NO`.

* mw65_black.h: update matrix diagram

* rename LAYOUT to LAYOUT_65_ansi_blocker

* add LAYOUT_65_ansi_blocker_tsangan

* info.json: correct maintainer value
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@noroadsleft
MWStudio MW65 Black Refactor (qmk#18824)
f8f1cd7 
* mw65_black.h: add matrix diagram

* mw65_black.h: fill-in matrix definition

Fill the empty electrical positions with `KC_NO`.

* mw65_black.h: update matrix diagram

* rename LAYOUT to LAYOUT_65_ansi_blocker

* add LAYOUT_65_ansi_blocker_tsangan

* info.json: correct maintainer value
thystips pushed a commit to thystips/qmk_firmware that referenced this pull request Nov 24, 2022
@noroadsleft @thystips
MWStudio MW65 Black Refactor (qmk#18824)
f96936c 
* mw65_black.h: add matrix diagram

* mw65_black.h: fill-in matrix definition

Fill the empty electrical positions with `KC_NO`.

* mw65_black.h: update matrix diagram

* rename LAYOUT to LAYOUT_65_ansi_blocker

* add LAYOUT_65_ansi_blocker_tsangan

* info.json: correct maintainer value
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@noroadsleft @ramonimbao
MWStudio MW65 Black Refactor (qmk#18824)
8c1bbd6 
* mw65_black.h: add matrix diagram

* mw65_black.h: fill-in matrix definition

Fill the empty electrical positions with `KC_NO`.

* mw65_black.h: update matrix diagram

* rename LAYOUT to LAYOUT_65_ansi_blocker

* add LAYOUT_65_ansi_blocker_tsangan

* info.json: correct maintainer value
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@noroadsleft @nolanseaton
MWStudio MW65 Black Refactor (qmk#18824)
52eefaa 
* mw65_black.h: add matrix diagram

* mw65_black.h: fill-in matrix definition

Fill the empty electrical positions with `KC_NO`.

* mw65_black.h: update matrix diagram

* rename LAYOUT to LAYOUT_65_ansi_blocker

* add LAYOUT_65_ansi_blocker_tsangan

* info.json: correct maintainer value
ChrisChrisLoLo pushed a commit to ChrisChrisLoLo/qmk_firmware that referenced this pull request Sep 2, 2023
@noroadsleft @ChrisChrisLoLo
MWStudio MW65 Black Refactor (qmk#18824)
726d42a 
* mw65_black.h: add matrix diagram

* mw65_black.h: fill-in matrix definition

Fill the empty electrical positions with `KC_NO`.

* mw65_black.h: update matrix diagram

* rename LAYOUT to LAYOUT_65_ansi_blocker

* add LAYOUT_65_ansi_blocker_tsangan

* info.json: correct maintainer value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noroadsleft @fauxpark @zvecr