Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align audio keycode names #18962

Merged
merged 5 commits into from
Nov 5, 2022
Merged

Align audio keycode names #18962

merged 5 commits into from
Nov 5, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Nov 5, 2022 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from fauxpark November 5, 2022 12:54
@github-actions github-actions bot added the core label Nov 5, 2022
fauxpark
fauxpark requested changes Nov 5, 2022
View reviewed changes
data/constants/keycodes/keycodes_0.0.1_audio.hjson Outdated Show resolved Hide resolved
data/constants/keycodes/keycodes_0.0.1_audio.hjson Outdated Show resolved Hide resolved
data/constants/keycodes/keycodes_0.0.1_audio.hjson Outdated Show resolved Hide resolved
data/constants/keycodes/keycodes_0.0.1_audio.hjson Outdated Show resolved Hide resolved
data/constants/keycodes/keycodes_0.0.1_audio.hjson Outdated Show resolved Hide resolved
data/constants/keycodes/keycodes_0.0.1_audio.hjson Outdated Show resolved Hide resolved
data/constants/keycodes/keycodes_0.0.1_audio.hjson Outdated Show resolved Hide resolved
data/constants/keycodes/keycodes_0.0.1_audio.hjson Outdated Show resolved Hide resolved
data/constants/keycodes/keycodes_0.0.1_audio.hjson Outdated Show resolved Hide resolved
quantum/quantum_keycodes_legacy.h Outdated Show resolved Hide resolved
@zvecr zvecr marked this pull request as ready for review November 5, 2022 17:04
@zvecr zvecr merged commit 69fa02c into qmk:develop Nov 5, 2022
@zvecr zvecr deleted the feature/audio_keycodes branch November 23, 2022 19:34
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@zvecr @ramonimbao
Align audio keycode names (qmk#18962)
7f05e8a 
* Align audio keycode names

* Update docs

* Update quantum
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@zvecr @elpekenin
Align audio keycode names (qmk#18962)
276e027 
* Align audio keycode names

* Update docs

* Update quantum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @fauxpark