Fix Typo in Saevus Cor Matrix #19073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent columns. This caused issues with multiple key presses and some keys not registering as they where connected to D3
|
@ramonimbao after building one of the protos, I ran into issues after flashing with the FW in main. I looked to see if there was an existing PR, but couldn't find one. Traced the columns with a multi-meter to find the correct pin for the Equals. |
|
My bad. Wasn't reported of any problems with the firmware. |
The firmware that was already on the solder board worked as expected. Just notice it when I went to add my own keymap not using via. |
drashna
approved these changes
Nov 20, 2022
fauxpark
approved these changes
Nov 20, 2022
thystips
pushed a commit
to thystips/qmk_firmware
that referenced
this pull request
Nov 24, 2022
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
elpekenin
pushed a commit
to elpekenin/qmk_firmware
that referenced
this pull request
Dec 7, 2022
crembz
pushed a commit
to crembz/qmk_firmware
that referenced
this pull request
Dec 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
D2 was duplicated in the Matrix, and assigned to 2 different columns.. This causes both multiple key presses (BS/equal) as well as some keys not working due to their connection to D3. This just updates the matrix in info.json to match the PCB.
Verified on pcb, and via tracing the matrix.
Types of Changes
Issues Fixed or Closed by This PR
Checklist