Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update files changed action #19172

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Update files changed action #19172

merged 1 commit into from
Nov 28, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Nov 27, 2022 •
edited
Loading

Description

Seems the old action isnt being updated, and suffers from

  • node 12 warnings
  • set-output deprecated warnings

Initial testing seems the action behaves similar enough

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team November 27, 2022 20:44
@github-actions github-actions bot added the CI label Nov 27, 2022
@zvecr zvecr marked this pull request as ready for review November 27, 2022 21:01
@drashna drashna requested a review from a team November 27, 2022 21:46
@zvecr zvecr merged commit 393a37c into qmk:develop Nov 28, 2022
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@zvecr @elpekenin
Update files changed action (qmk#19172)
ca76720
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@zvecr @omikronik
Update files changed action (qmk#19172)
46760da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @drashna @tzarc