Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the Gone Hacking Studio XLS #19185

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Add the Gone Hacking Studio XLS #19185

merged 2 commits into from
Dec 13, 2022

Conversation

ramonimbao
Copy link
Contributor

Description

Adds the Gone Hacking Studio XLS. I had a previous PR I messed up so this is a redo: #18362 This does include all the latest changes requested though (missing license headers, encoder map support).

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Nov 28, 2022
@drashna drashna requested a review from a team December 3, 2022 20:10
fauxpark
fauxpark requested changes Dec 4, 2022
View reviewed changes
keyboards/ghs/xls/keymaps/via/keymap.c Outdated Show resolved Hide resolved
@ramonimbao @fauxpark
Update keyboards/ghs/xls/keymaps/via/keymap.c
369ad91 
Co-authored-by: Ryan <fauxpark@gmail.com>
@drashna drashna merged commit 812468a into qmk:master Dec 13, 2022
@ramonimbao ramonimbao mentioned this pull request Dec 13, 2022
Merged
6 tasks
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@ramonimbao @fauxpark @crembz
[Keyboard] Add the Gone Hacking Studio XLS (qmk#19185)
8289788 
Co-authored-by: Ryan <fauxpark@gmail.com>
sbhal pushed a commit to sbhal/qmk_firmware that referenced this pull request Dec 30, 2022
@ramonimbao @fauxpark
[Keyboard] Add the Gone Hacking Studio XLS (qmk#19185)
b35e816 
Co-authored-by: Ryan <fauxpark@gmail.com>
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@ramonimbao @fauxpark @omikronik
[Keyboard] Add the Gone Hacking Studio XLS (qmk#19185)
a15076b 
Co-authored-by: Ryan <fauxpark@gmail.com>
ideas32 pushed a commit to ideas32/qmk_firmware that referenced this pull request Jan 25, 2023
@ramonimbao @fauxpark @ideas32
[Keyboard] Add the Gone Hacking Studio XLS (qmk#19185)
4fc9da2 
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramonimbao @drashna @fauxpark