Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KEYBOARD] add YMDK40 AIR40 #19276

Merged
merged 9 commits into from
Jan 10, 2023
Merged

[KEYBOARD] add YMDK40 AIR40 #19276

merged 9 commits into from
Jan 10, 2023

Conversation

dkruyt
Copy link
Contributor

@dkruyt dkruyt commented Dec 9, 2022

Description

YMDK40 has a "new" AIR40 board, this will add support for their board, also will use per key RGB matrix.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Dec 9, 2022
waffle87
waffle87 requested changes Dec 9, 2022
View reviewed changes
keyboards/ymdk/ymd40/air40/air40.c Outdated Show resolved Hide resolved
keyboards/ymdk/ymd40/air40/config.h Outdated Show resolved Hide resolved
keyboards/ymdk/ymd40/air40/keymaps/default/readme.md Outdated Show resolved Hide resolved
keyboards/ymdk/ymd40/air40/keymaps/via/readme.md Outdated Show resolved Hide resolved
keyboards/ymdk/ymd40/air40/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/ymdk/ymd40/air40/keymaps/via/keymap.c Outdated Show resolved Hide resolved
dkruyt and others added 4 commits December 9, 2022 19:01
@dkruyt @waffle87
Update keyboards/ymdk/ymd40/air40/keymaps/via/keymap.c
78d6877 
Co-authored-by: jack <0x6a73@protonmail.com>
@dkruyt @waffle87
Update keyboards/ymdk/ymd40/air40/keymaps/default/keymap.c
4757746 
Co-authored-by: jack <0x6a73@protonmail.com>
@dkruyt @waffle87
Update keyboards/ymdk/ymd40/air40/config.h
2c4d9f6 
Co-authored-by: jack <0x6a73@protonmail.com>
@dkruyt
readme
1968f42
@estbndlt
Copy link

This is awesome! Would adding this allow VIA to configure the RGB settings as well?

@dkruyt
Copy link
Contributor Author

dkruyt commented Dec 12, 2022

This is awesome! Would adding this allow VIA to configure the RGB settings as well?

Yes!!!

dkruyt and others added 2 commits December 14, 2022 21:33
@dkruyt @drashna
Update keyboards/ymdk/ymd40/air40/rules.mk
0e45f89 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@dkruyt @waffle87
Update keyboards/ymdk/ymd40/air40/air40.c
23ef08e 
Co-authored-by: jack <0x6a73@protonmail.com>
@dkruyt @drashna
Update keyboards/ymdk/ymd40/air40/config.h
8f1b333 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@dkruyt
Copy link
Contributor Author

dkruyt commented Dec 29, 2022

Tested and verified by someone else... https://www.reddit.com/r/olkb/comments/zuzvf4/ymdk_air40_leds_only_working_for_8_keys/j1mjdw7/?context=3

drashna
drashna reviewed Dec 31, 2022
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also help with compilation/CI errors.

keyboards/ymdk/ymd40/air40/rules.mk Show resolved Hide resolved
@dkruyt @drashna
Update keyboards/ymdk/ymd40/air40/rules.mk
fb151b6 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@drashna drashna requested a review from a team January 1, 2023 16:07
@drashna drashna merged commit caca029 into qmk:master Jan 10, 2023
sboysel pushed a commit to sboysel/qmk_firmware that referenced this pull request Jan 17, 2023
@dkruyt @waffle87
@drashna @sboysel
[Keyboard] add YMDK40 AIR40 (qmk#19276)
180aa1b 
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@dkruyt @waffle87
@drashna @omikronik
[Keyboard] add YMDK40 AIR40 (qmk#19276)
33366df 
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
ideas32 pushed a commit to ideas32/qmk_firmware that referenced this pull request Jan 25, 2023
@dkruyt @waffle87
@drashna @ideas32
[Keyboard] add YMDK40 AIR40 (qmk#19276)
9508f54 
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@waffle87 waffle87 waffle87 requested changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dkruyt @estbndlt @drashna @fauxpark @waffle87