Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tap Dance: remove qk_ prefix #19313

Merged
merged 7 commits into from
Dec 14, 2022
Merged

Tap Dance: remove qk_ prefix #19313

merged 7 commits into from
Dec 14, 2022

Conversation

fauxpark
Copy link
Member

Description

#19304

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark added enhancement core keymap documentation via Adds via keymap and/or updates keyboard for via support labels Dec 14, 2022
@fauxpark fauxpark requested a review from a team December 14, 2022 04:49
@drashna drashna merged commit 1978007 into qmk:develop Dec 14, 2022
@fauxpark fauxpark deleted the tap-dance-remove-qk-prefix branch December 15, 2022 01:52
precondition added a commit to precondition/dactyl-manuform-keymap that referenced this pull request Jan 1, 2023
@precondition
Remove qk_ prefix in tap dance code
f47c48b 
See qmk/qmk_firmware#19313
precondition added a commit to precondition/polilla-keymap that referenced this pull request Jan 1, 2023
@precondition
Remove qk_ prefix in tap dance code
fbb2ed6 
See qmk/qmk_firmware#19313
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@fauxpark @omikronik
Tap Dance: remove qk_ prefix (qmk#19313)
9536ab6
@lesshonor lesshonor mentioned this pull request Mar 9, 2023
Closed
2 tasks
@chrishoage chrishoage mentioned this pull request Apr 30, 2023
Merged
14 tasks
@zvecr zvecr mentioned this pull request Apr 23, 2024
Closed
2 tasks
@JaloDO JaloDO mentioned this pull request May 23, 2024
Open
JaloDO added a commit to JaloDO/crkbd_qmk_spanish_map that referenced this pull request May 23, 2024
@JaloDO
Update keymap.c
e427249 
1) COMENTAR LA LINEA

	//#define IGNORE_MOD_TAP_INTERRUPT

	- Compiling: quantum/action_tapping.c                                                                
					quantum/action_tapping.c:15:10: error: #error 
					"IGNORE_MOD_TAP_INTERRUPT is no longer necessary as it is now the default behavior of mod-tap keys.
					Please remove it from your config."
					
2) ASIGNAR NOMBRE AL TIPO DE LAYOUT

3) TECLA RESET -> QK_BOOT
4) TECLAS: 	KC__MUTE -> KC_MUTE
			KC__VOLUP -> KC_VOLU
			KC__VOLDOWN -> KC_VOLD
			
5) ELIMINAR PREFIJO qk_
	qk_tap_dance_action_t -> tap_dance_action_t
	- Prefix qk_ removed -> Pull Request qmk/qmk_firmware#19313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation enhancement keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fauxpark @drashna @tzarc @zvecr