Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate keyboard name before accepting further input #19394

Merged
merged 2 commits into from
Dec 23, 2022
Merged

Validate keyboard name before accepting further input #19394

merged 2 commits into from
Dec 23, 2022

Conversation

waffle87
Copy link
Member

Description

As title. Otherwise, the user will input various other info before an error is raised.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command python labels Dec 21, 2022
@drashna drashna requested a review from a team December 23, 2022 08:55
@zvecr zvecr merged commit 003cee0 into qmk:develop Dec 23, 2022
@waffle87 waffle87 deleted the patch/new_keyboard branch December 23, 2022 18:20
@Onefabis Onefabis mentioned this pull request Dec 24, 2022
Closed
2 tasks
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@waffle87 @omikronik
Validate keyboard name before accepting further input (qmk#19394)
b0c80a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waffle87 @fauxpark @zvecr