Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RGB matrix reactive gradient timer scale #19415

Merged
merged 1 commit into from
Dec 30, 2022
Merged

Update RGB matrix reactive gradient timer scale #19415

merged 1 commit into from
Dec 30, 2022

Conversation

filterpaper
Copy link
Contributor

@filterpaper filterpaper commented Dec 24, 2022 •
edited
Loading

Description

  • Gradient changes is more obvious with this timer scale at both ends of effect speed
  • Use qadd8 to cap speed upper limit
  • Fix gradient implementation for reactive nexus effect

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Dec 24, 2022
@filterpaper filterpaper changed the title [Core] Update RGB matrix reactive gradient scale [Core] Update RGB matrix reactive gradient timer scale Dec 24, 2022
@filterpaper filterpaper changed the title [Core] Update RGB matrix reactive gradient timer scale Update RGB matrix reactive gradient timer scale Dec 24, 2022
@drashna drashna requested a review from a team December 27, 2022 20:13
@tzarc tzarc merged commit 7709267 into qmk:develop Dec 30, 2022
@filterpaper filterpaper deleted the reactive_gradient_refactor branch December 30, 2022 04:20
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@filterpaper @omikronik
Update RGB matrix reactive gradient timer scale (qmk#19415)
7a34208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@filterpaper @drashna @tzarc @fauxpark