Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qmk compile/qmk flash - Validate keymap argument #19530

Merged
merged 2 commits into from
Jan 19, 2023
Merged

qmk compile/qmk flash - Validate keymap argument #19530

merged 2 commits into from
Jan 19, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 7, 2023 •
edited
Loading

Description

Avoids,

$ qmk compile -kb keychron/q1/ansi_encoder -km ~/Downloads/zed.json 
Ψ Compiling keymap with make --jobs=1 keychron/q1/ansi_encoder:/home/zvecr/Downloads/zed.json


QMK Firmware 0.19.6
Making keychron/q1/ansi_encoder with keymap default and target /home/zvecr/Downloads/zed.json  [OK]
Making keychron/q1/ansi_encoder with keymap keychron and target /home/zvecr/Downloads/zed.json [OK]
Making keychron/q1/ansi_encoder with keymap via and target /home/zvecr/Downloads/zed.json      [OK]

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command python labels Jan 7, 2023
@zvecr zvecr requested a review from a team January 7, 2023 17:39
@zvecr zvecr force-pushed the feature/validate_keymap_arg branch from 60fc076 to c79dd16 Compare January 11, 2023 15:22
@zvecr
Copy link
Member Author

zvecr commented Jan 11, 2023

With #19562, validation of community keymaps is now working as expected too.

@zvecr zvecr merged commit a1f253c into qmk:develop Jan 19, 2023
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@zvecr @omikronik
qmk compile/qmk flash - Validate keymap argument (qmk#19530)
9ab6ff1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @tzarc