Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PMW3320 driver #19543

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Added PMW3320 driver #19543

merged 2 commits into from
Apr 3, 2023

Conversation

Vladeeg
Copy link
Contributor

@Vladeeg Vladeeg commented Jan 8, 2023

Description

Added support for Pixart PMW3320 optical sensor.

Since PMW3320 sensor's datasheets are not really descriptive in terms of programming and I don't really have experience in hardware reverse engineering, some parts of implementation are guesses.

I used ADNS5050 driver as a base for this driver, so some "hacks" are from here.

I'm pretty sure that some initial settings in pmw3320_init function are device-specific, but haven't found any similar settings for other sensor in other devices folders, so I'm not sure where to put them.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

None

Checklist

@zvecr zvecr changed the base branch from master to develop January 8, 2023 15:23
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the register comment, it looks good

drivers/sensors/pmw3320.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team January 9, 2023 09:04
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, the driver appears to be fine, as is.

Most of my feedback is "it might be better", but isn't strictly required.

@drashna drashna requested a review from a team January 10, 2023 03:10
drivers/sensors/pmw3320.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team January 12, 2023 19:24
@tzarc tzarc merged commit 9a68472 into qmk:develop Apr 3, 2023
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants