Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote CTPC warning to error #19565

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Promote CTPC warning to error #19565

merged 1 commit into from
Jan 11, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 11, 2023 •
edited
Loading

Description

Previous cycle warn, this cycle error, next remove.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team January 11, 2023 20:13
daskygit
daskygit approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@daskygit daskygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we switch over any keymaps using CTPC?

@zvecr
Copy link
Member Author

zvecr commented Jan 11, 2023 •
edited
Loading

For some reason I thought i had already, but it looks like still some hits.

#19570 should cover the existing cases.

@zvecr zvecr mentioned this pull request Jan 11, 2023
Merged
14 tasks
@zvecr zvecr merged commit 1bbacec into qmk:develop Jan 11, 2023
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@zvecr @omikronik
Promote CTPC warning to error (qmk#19565)
eaddda7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daskygit daskygit daskygit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @daskygit