Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce _validate complexity #20274

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Reduce _validate complexity #20274

merged 1 commit into from
Mar 28, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 27, 2023 •
edited
Loading

Description

lib/python/qmk/info.py:53:1: C901 '_validate' is too complex (17)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Mar 27, 2023
@zvecr zvecr requested a review from a team March 27, 2023 20:02
@github-actions github-actions bot added cli qmk cli command python labels Mar 27, 2023
@zvecr zvecr merged commit f186abd into qmk:develop Mar 28, 2023
nicsuzor pushed a commit to nicsuzor/qmk_firmware that referenced this pull request Mar 28, 2023
@zvecr @nicsuzor
Reduce _validate complexity (qmk#20274)
fe08cd5
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@zvecr @coquizen
Reduce _validate complexity (qmk#20274)
fcaa578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
bug cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @fauxpark