Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Clean up ISSI drivers, Add IS31FL3736 support #20572

Merged
merged 8 commits into from
Apr 30, 2023
Merged

[Core] Clean up ISSI drivers, Add IS31FL3736 support #20572

merged 8 commits into from
Apr 30, 2023

Conversation

Xelus22
Copy link
Contributor

@Xelus22 Xelus22 commented Apr 26, 2023 •
edited
Loading

Description

Fixup ISSI drivers

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Clean up IS31FL3736 header
  • Clean up IS31FL3737 header
  • More consistent code
  • Add missing IS31FL3736 support and documentation even though the driver is there already.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Xelus22 Xelus22 changed the title [Core] Clean up ISSI drivers to be more consistent and fixup 3736 and 3737 headers [Core] Clean up ISSI drivers, Add IS31FL3736 support Apr 26, 2023
drashna
drashna approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on moonlander which uses dual 3731's, and no appreciable slowdown or impact, at least

@Xelus22 @elpekenin
Fix IS31FL3218
558fbe6 
Co-authored-by: Pablo Martínez <58857054+elpekenin@users.noreply.github.com>
@tzarc tzarc merged commit 6a619e6 into qmk:develop Apr 30, 2023
@filterpaper filterpaper mentioned this pull request Apr 30, 2023
Merged
14 tasks
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@Xelus22 @elpekenin @coquizen
[Core] Clean up ISSI drivers, Add IS31FL3736 support (qmk#20572)
5a073e8 
Co-authored-by: Pablo Martínez <58857054+elpekenin@users.noreply.github.com>
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@Xelus22 @elpekenin @autoferrit
[Core] Clean up ISSI drivers, Add IS31FL3736 support (qmk#20572)
f337fb5 
Co-authored-by: Pablo Martínez <58857054+elpekenin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpekenin elpekenin elpekenin left review comments

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xelus22 @drashna @tzarc @elpekenin