Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Disable debug on QP's internal task #20623

Merged
merged 7 commits into from
May 2, 2023
Merged

[Feature] Disable debug on QP's internal task #20623

merged 7 commits into from
May 2, 2023

Conversation

elpekenin
Copy link
Contributor

@elpekenin elpekenin commented Apr 29, 2023 •
edited
Loading

Description

#20013 introduced auto-flushing on QP's internal task, however this leads to a problem when debugging, as the console gets a spam of qp_flush messages, thus added a define to disable output while the task perform the flushes

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

tzarc
tzarc requested changes Apr 29, 2023
View reviewed changes
docs/quantum_painter.md Outdated Show resolved Hide resolved
quantum/painter/qp_internal.c Outdated Show resolved Hide resolved
quantum/painter/qp_internal.c Outdated Show resolved Hide resolved
elpekenin and others added 3 commits April 29, 2023 20:30
@elpekenin @tzarc
Update docs/quantum_painter.md
a8b114b 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@elpekenin @tzarc
Update quantum/painter/qp_internal.c
5385352 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@elpekenin
Update qp_internal.c
c9a1f6c
@elpekenin elpekenin requested a review from tzarc April 29, 2023 18:32
@tzarc tzarc requested a review from a team April 30, 2023 01:53
@drashna drashna merged commit 82a34ae into qmk:develop May 2, 2023
@elpekenin elpekenin deleted the feature/qp-flush-output branch May 2, 2023 09:01
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@elpekenin @tzarc @coquizen
[Feature] Disable debug on QP's internal task (qmk#20623)
e280487 
Co-authored-by: Nick Brassel <nick@tzarc.org>
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@elpekenin @tzarc @autoferrit
[Feature] Disable debug on QP's internal task (qmk#20623)
413996b 
Co-authored-by: Nick Brassel <nick@tzarc.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elpekenin @drashna @tzarc