Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Decouple autocorrect logic #21116

Merged
merged 2 commits into from
Jun 4, 2023
Merged

[Enhancement] Decouple autocorrect logic #21116

merged 2 commits into from
Jun 4, 2023

Conversation

elpekenin
Copy link
Contributor

@elpekenin elpekenin commented Jun 2, 2023 •
edited
Loading

Description

Rigth now the weak function contains a lot of functionality that users may want to extend instead of completely override (eg: me 🙃), thus decoupling this into a function, to avoid duplications.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jun 2, 2023
@drashna drashna requested a review from a team June 2, 2023 21:58
@zvecr zvecr merged commit edaf665 into qmk:develop Jun 4, 2023
@elpekenin elpekenin deleted the autocorrect_hook branch June 4, 2023 06:21
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
@elpekenin @jesperhellberg
[Enhancement] Decouple autocorrect logic (qmk#21116)
7458465
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
@elpekenin @thismarvin
[Enhancement] Decouple autocorrect logic (qmk#21116)
e9fac3d
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
@elpekenin @akeep
[Enhancement] Decouple autocorrect logic (qmk#21116)
bf995f3
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
@elpekenin @csolje
[Enhancement] Decouple autocorrect logic (qmk#21116)
c0a0cc1
jashort pushed a commit to jashort/qmk_firmware that referenced this pull request Nov 20, 2023
@elpekenin @jashort
[Enhancement] Decouple autocorrect logic (qmk#21116)
b843758
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@elpekenin @autoferrit
[Enhancement] Decouple autocorrect logic (qmk#21116)
380c969
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elpekenin @drashna @zvecr