Get rid of USB_LED_CAPS_LOCK
#21436
Merged
Get rid of USB_LED_CAPS_LOCK
#21436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
requested changes
Jul 3, 2023
keyboards/lazydesigners/dimple/staggered/keymaps/tominabox1/keymap.c
Outdated
Show resolved
Hide resolved
Co-authored-by: Joel Challis <git@zvecr.com>
zvecr
reviewed
Jul 3, 2023
| @@ -190,7 +193,7 @@ void sleep_led_toggle(void) { | |||
| void sleep_led_init(void) {} | |||
|
|
|||
| void sleep_led_enable(void) { | |||
| led_set(1 << USB_LED_CAPS_LOCK); | |||
| led_set(2); // Caps Lock | |||
There was a problem hiding this comment.
Would it not be better to avoid magics by doing the same as whats above?
led_state.caps_lock = true;
led_set(led_state.raw);
There was a problem hiding this comment.
This is just a temporary measure; the plan is to get rid of everything in the indicator API that operates on uint8_t, and replace it with led_t. I just didn't want to lump all of that extra work in this PR.
drashna
approved these changes
Jul 3, 2023
zvecr
approved these changes
Jul 6, 2023
jesperhellberg
pushed a commit
to jesperhellberg/qmk_firmware
that referenced
this pull request
Sep 9, 2023
thismarvin
pushed a commit
to thismarvin/qmk_firmware
that referenced
this pull request
Sep 27, 2023
akeep
pushed a commit
to akeep/qmk_firmware
that referenced
this pull request
Oct 2, 2023
csolje
pushed a commit
to csolje/qmk_firmware
that referenced
this pull request
Oct 21, 2023
jashort
pushed a commit
to jashort/qmk_firmware
that referenced
this pull request
Nov 20, 2023
autoferrit
pushed a commit
to SpaceRockMedia/bastardkb-qmk
that referenced
this pull request
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist