From e5577d50d2b4b3a9f8c9e5b398146e95d930fd4c Mon Sep 17 00:00:00 2001 From: lendunistus <53618962+lendunistus@users.noreply.github.com> Date: Sun, 17 Sep 2023 08:08:36 +0300 Subject: [PATCH 1/2] PR Checklist format-json reminder --- docs/pr_checklist.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/pr_checklist.md b/docs/pr_checklist.md index c98504c8c0c5..c1ca031b8299 100644 --- a/docs/pr_checklist.md +++ b/docs/pr_checklist.md @@ -80,6 +80,7 @@ https://github.com/qmk/qmk_firmware/pulls?q=is%3Apr+is%3Aclosed+label%3Akeyboard - Encoder Configuration - Bootmagic Configuration - LED Indicator Configuration + - run `qmk format-json` on this file before submitting your PR - `readme.md` - must follow the [template](https://github.com/qmk/qmk_firmware/blob/master/data/templates/keyboard/readme.md) - flash command is present, and has `:flash` at end From 0612fcbda5604d7c518e2d832746ae6c17599fed Mon Sep 17 00:00:00 2001 From: lendunistus <53618962+lendunistus@users.noreply.github.com> Date: Sun, 17 Sep 2023 20:43:26 +0300 Subject: [PATCH 2/2] Applied suggested clarification --- docs/pr_checklist.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/pr_checklist.md b/docs/pr_checklist.md index c1ca031b8299..9bf1b8d0056c 100644 --- a/docs/pr_checklist.md +++ b/docs/pr_checklist.md @@ -80,7 +80,7 @@ https://github.com/qmk/qmk_firmware/pulls?q=is%3Apr+is%3Aclosed+label%3Akeyboard - Encoder Configuration - Bootmagic Configuration - LED Indicator Configuration - - run `qmk format-json` on this file before submitting your PR + - Run `qmk format-json` on this file before submitting your PR. Be sure to append the `-i` flag to directly modify the file, or paste the outputted code into the file. - `readme.md` - must follow the [template](https://github.com/qmk/qmk_firmware/blob/master/data/templates/keyboard/readme.md) - flash command is present, and has `:flash` at end