Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update naming convention for GPIO control macros #23085

Merged
merged 6 commits into from
Feb 16, 2024
Merged

Update naming convention for GPIO control macros #23085

merged 6 commits into from
Feb 16, 2024

Conversation

fauxpark
Copy link
Member

Description

snake_case with gpio_ prefix to align better with the rest of the codebase.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team February 15, 2024 10:40
@fauxpark fauxpark merged commit b8646bc into qmk:develop Feb 16, 2024
4 checks passed
@fauxpark fauxpark deleted the gpio-macros-naming branch February 16, 2024 13:18
@fauxpark fauxpark mentioned this pull request Feb 16, 2024
Merged
14 tasks
@fauxpark fauxpark mentioned this pull request May 26, 2024
Open
14 tasks
atechofficials added a commit to atechofficials/qmk_firmware that referenced this pull request Jul 10, 2024
@atechofficials @fauxpark
Update keyboards/protokeeb/rev1/rev1.c
739ff79 
Renaming Arduino-style GPIO pin functions (qmk#23085, qmk#23093)

Co-authored-by: Ryan <fauxpark@gmail.com>
atechofficials added a commit to atechofficials/qmk_firmware that referenced this pull request Jul 13, 2024
@atechofficials
Changed readPin function to gpio_read_pin function in rev1.c file bec…
cb54da6 
…ause of core change: Renaming Arduino-style GPIO pin functions qmk#23085, qmk#23093
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@fauxpark @nuess0r
Update naming convention for GPIO control macros (qmk#23085)
16fcd5a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core documentation enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @tzarc @zvecr