Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated quantum keycodes #23407

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Remove deprecated quantum keycodes #23407

merged 1 commit into from
Apr 4, 2024

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Apr 3, 2024

Description

I think it's been long enough that we can fully kill these off now. Leaving the header in place as there are still keycodes I'd like to rework, such as the splitting of backlight/LED Matrix and RGBLight/RGB Matrix.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark added enhancement core keyboard keymap documentation via Adds via keymap and/or updates keyboard for via support labels Apr 3, 2024
@fauxpark fauxpark requested a review from a team April 3, 2024 13:05
@fauxpark
Copy link
Member Author

fauxpark commented Apr 3, 2024

Build failures unrelated; fixed by #23406

@zvecr zvecr merged commit 2a25e79 into qmk:develop Apr 4, 2024
5 checks passed
@fauxpark fauxpark deleted the remove-deprecated-keycodes branch April 4, 2024 14:19
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@fauxpark @whoisjordangarcia
Remove deprecated quantum keycodes (qmk#23407)
f733d71
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@fauxpark @nuess0r
Remove deprecated quantum keycodes (qmk#23407)
c8898d1
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@fauxpark @Ardakilic
Remove deprecated quantum keycodes (qmk#23407)
628b62c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core documentation enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @zvecr @dunk2k