[Core] Add Layer Lock feature #23430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getreuer
reviewed
Jun 8, 2024
|
This is great! Thank you drashna for making this PR to add Layer Lock in QMK core. Please let me know if I can be of help. |
welcome! and mostly, I think I just need to write docs for this. The main issue being where to add them. |
drashna
force-pushed
the
feature/layer_lock
branch
from
d8a4ddb
to
8370f4c
Compare
This commit builds on @drashna's qmk#23430 to add documentation: * New page docs/features/layer_lock.md added describing Layer Lock. * Added link to this page in docs/_sidebar.json * And in docs/keycodes.md * And a cross-reference in docs/feature_layers.md NOTE: Beware, I haven't checked this documentation locally with `qmk docs` (the command failed with a problem involving yarn). So there might be formatting bugs and broken links in this.
getreuer
reviewed
Jun 14, 2024
getreuer
approved these changes
Jun 19, 2024
|
Nit: "I have updated the documentation accordingly" in the PR checklist can now be checked 👍 |
drashna
changed the title
iamdanielv
reviewed
Aug 18, 2024
|
This is a really cool feature, excited to see it incorporated into main! |
iamdanielv
reviewed
Aug 30, 2024
because drashna never makes spelling mistakes! Co-authored-by: Daniel <1767914+iamdanielv@users.noreply.github.com>
tzarc
approved these changes
Nov 21, 2024
14 tasks
ilham-agustiawan
pushed a commit
to ilham-agustiawan/qmk_firmware
that referenced
this pull request
Nov 30, 2024
Co-authored-by: Daniel <1767914+iamdanielv@users.noreply.github.com> Co-authored-by: Pascal Getreuer <getreuer@google.com> Co-authored-by: Pascal Getreuer <50221757+getreuer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist