Configurator layout repair for Ergodone, Ergodox Infinity and ErgoTravel #3173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noroadsleft
force-pushed
the
c10r-ergodoxes
branch
from
6b189e8
to
321b8a0
Compare
|
Travis Errors are unrelated to this change. |
|
Thanks! |
noj
added a commit
to noj/qmk_firmware
that referenced
this pull request
Jun 16, 2018
…jan_atreus * 'master' of https://github.com/qmk/qmk_firmware: (578 commits) Contra refactor (qmk#3191) Fixed no-op ifndef for ergodox ez (qmk#3189) Canoe Refactor (qmk#3190) planck/light/info.json fix (qmk#3186) Tada68 refactor and readme update (qmk#3178) Add URL of PCB files to README.md (qmk#3182) Rename from KEYMAP to LAYOUT (qmk#3181) Fix bfake matrix bug (qmk#3180) Clueboard 2x1800 Refactor (qmk#3179) QMK Configurator Support for Melody96 (qmk#3177) Lightsaver info.json update (qmk#3176) KBD66 info.json update (qmk#3175) Mbsurfer deltasplit75 keymap (qmk#3174) Configurator layout repair for Ergodone, Ergodox Infinity and ErgoTravel (qmk#3173) Ergodox EZ refactor (qmk#3171) Hadron: Readme, Refactor, and Configurator support (qmk#3170) fix issue with rgbinit unused variable (qmk#3165) Fix melody96 default keymap graphic. (qmk#3169) Fix jj40 capslock and minor keymap updates (qmk#3168) GON NerD: Refactor, Configurator support and Readme cleanup (qmk#3167) ...
yamad
pushed a commit
to yamad/qmk_firmware
that referenced
this pull request
Apr 10, 2019
…vel (qmk#3173) * Ergodone refactor * Ergodox Infinity refactor * Ergotravel refactor * Ergotravel configurator layout update * Fixing include on Ergodox Infinity narze keymap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the work of #3052, #3053, and #3171
Assuming I haven't screwed anything up (a dangerous assumption), this should fix the Configurator API errors on the Ergodone, Ergodox Infinity, and the ErgoTravel.
Requesting review from @drashna and @mechmerlin, and maybe @skullydazed if he's not still wrapped up in household tasks demanding his attention.
Ergodone
Matrices
KEYMAPLAYOUT_ergodoxKEYMAP_PRETTYLAYOUT_ergodox_prettyErgodox Infinity
Matrices
KEYMAPLAYOUT_ergodoxKEYMAP_PRETTYLAYOUT_ergodox_prettyKeymaps
narzekeymap now usesQMK_KEYBOARD_HincludeErgoTravel
LAYOUTmacro fromLAYOUT_kcinfo.json