-
-
Notifications
You must be signed in to change notification settings - Fork 39.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove vusb 'reset to bootloader' hid message due to security implications #7456
Conversation
Some context- Since QMK is probably the most popular keyboard firmware we are the most likely platform to be targeted for attacks. With this code in place it's possible for a malicious actor to load compromised firmware into a user's keyboard without the user's knowledge. |
This is to go to bootloader from host yes? |
Is there the same problem in VIA? Here: Lines 377 to 385 in 0928496
|
Description
A malicious actor could send a well crafted hid message to a vusb board, which resets to bootloader. They would then be able to automatically flash firmware, without user intervention, firmware which is potentially compromised.
Types of Changes
Checklist