Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new keymap with split shift and split backspace for bananasplit PCB #8395

Merged
merged 3 commits into from
Mar 12, 2020
Merged

Add new keymap with split shift and split backspace for bananasplit PCB #8395

merged 3 commits into from
Mar 12, 2020

Conversation

christopherjanzen
Copy link
Contributor

Description

Provides an HHKB-like layout for the Bananasplit PCB

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft requested a review from a team March 12, 2020 08:33
@christopherjanzen christopherjanzen requested review from noroadsleft and removed request for a team March 12, 2020 12:39
@noroadsleft noroadsleft requested a review from a team March 12, 2020 19:07
@christopherjanzen @fauxpark
Remove unecessary line breaks
128f094 
Co-Authored-By: Ryan <fauxpark@gmail.com>
@fauxpark
Copy link
Member

Thanks!

@fauxpark fauxpark merged commit 4edb5a5 into qmk:master Mar 12, 2020
@christopherjanzen christopherjanzen deleted the cijanzen-bananasplit branch March 12, 2020 19:15
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Mar 14, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
835ef5a 
* 'master' of https://github.com/qmk/qmk_firmware: (27 commits)
  Add Portuguese keymap and sendstring lookup tables (qmk#8390)
  Update link for Learn Plover google site (qmk#8410)
  [Keymap] ninjonas keymap updates (qmk#8373)
  Fix bootloader for Maypad (qmk#8411)
  Add decorators for determining keyboard and keymap based on current directory (qmk#8191)
  format code according to conventions [skip ci]
  Fix pressing two keys with the same keycode but different modifiers (qmk#2710)
  format code according to conventions [skip ci]
  Decouple mouse cursor and mouse wheel in accelerated mode (qmk#6685)
  [Keyboard] Add Wallaby (qmk#8398)
  [Keyboard] Abacus Keyboard ReMerge (qmk#8308)
  Restore getting_started_github.md doc
  Update Swedish keymap and add sendstring LUT (qmk#8365)
  Update Spanish keymap and sendstring LUT (qmk#8364)
  use qmk.path.normpath to locate the output file.
  [Keyboard] Candybar update (qmk#8335)
  Add new keymap with split shift and split backspace for bananas… (qmk#8395)
  Enable custom backlight driver for kmac (qmk#8397)
  Force "blank" issue template to end of list (qmk#8387)
  Fix darkmode (qmk#8393)
  ...
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@christopherjanzen @fauxpark @c0psrul3
Add new keymap with split shift and split backspace for bananas… (qmk…
72b1263 
…#8395)

* Add new keymap with split right shift and split backspace for bananasplit PCB

* Remove unecessary config.h

* Remove unecessary line breaks

Co-Authored-By: Ryan <fauxpark@gmail.com>

Co-authored-by: Christopher Janzen <hello@christopherjanzen.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Apr 2, 2020
@christopherjanzen @fauxpark @sowbug
Add new keymap with split shift and split backspace for bananas… (qmk…
3441959 
…#8395)

* Add new keymap with split right shift and split backspace for bananasplit PCB

* Remove unecessary config.h

* Remove unecessary line breaks

Co-Authored-By: Ryan <fauxpark@gmail.com>

Co-authored-by: Christopher Janzen <hello@christopherjanzen.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Apr 10, 2020
@christopherjanzen @fauxpark @HokieGeek
Add new keymap with split shift and split backspace for bananas… (qmk…
5e095f2 
…#8395)

* Add new keymap with split right shift and split backspace for bananasplit PCB

* Remove unecessary config.h

* Remove unecessary line breaks

Co-Authored-By: Ryan <fauxpark@gmail.com>

Co-authored-by: Christopher Janzen <hello@christopherjanzen.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@christopherjanzen @fauxpark @kujawakk
Add new keymap with split shift and split backspace for bananas… (qmk…
e9bf924 
…#8395)

* Add new keymap with split right shift and split backspace for bananasplit PCB

* Remove unecessary config.h

* Remove unecessary line breaks

Co-Authored-By: Ryan <fauxpark@gmail.com>

Co-authored-by: Christopher Janzen <hello@christopherjanzen.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@christopherjanzen @fauxpark @jakobaa
Add new keymap with split shift and split backspace for bananas… (qmk…
7db40d1 
…#8395)

* Add new keymap with split right shift and split backspace for bananasplit PCB

* Remove unecessary config.h

* Remove unecessary line breaks

Co-Authored-By: Ryan <fauxpark@gmail.com>

Co-authored-by: Christopher Janzen <hello@christopherjanzen.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
@christopherjanzen @fauxpark @jakeisnt
Add new keymap with split shift and split backspace for bananas… (qmk…
1e3a6a8 
…#8395)

* Add new keymap with split right shift and split backspace for bananasplit PCB

* Remove unecessary config.h

* Remove unecessary line breaks

Co-Authored-By: Ryan <fauxpark@gmail.com>

Co-authored-by: Christopher Janzen <hello@christopherjanzen.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christopherjanzen @fauxpark @noroadsleft