Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Polish keymap #8637

Merged
merged 9 commits into from
Apr 5, 2020
Merged

Add Polish keymap #8637

merged 9 commits into from
Apr 5, 2020

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Apr 1, 2020

Description

🇵🇱

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team April 1, 2020 03:15
quantum/keymap_extras/keymap_polish.h Outdated Show resolved Hide resolved
quantum/keymap_extras/keymap_polish.h Outdated Show resolved Hide resolved
quantum/keymap_extras/keymap_polish.h Outdated Show resolved Hide resolved
quantum/keymap_extras/keymap_polish.h Show resolved Hide resolved
quantum/keymap_extras/keymap_polish.h Outdated Show resolved Hide resolved
quantum/keymap_extras/keymap_polish.h Outdated Show resolved Hide resolved
@vomindoraan
Copy link
Contributor

Could you bundle the following changes to the Slovak keymap together with this PR, please? I feel it doesn't deserve a PR of its own:

diff --git a/quantum/keymap_extras/keymap_slovak.h b/quantum/keymap_extras/keymap_slovak.h
index 7a02dcfdf..f0bd6ae51 100644
--- a/quantum/keymap_extras/keymap_slovak.h
+++ b/quantum/keymap_extras/keymap_slovak.h
@@ -36,10 +36,10 @@
 // Row 1
 #define SK_SCLN KC_GRV  // ;
 #define SK_PLUS KC_1    // +
-#define SK_LACU KC_2    // ľ
+#define SK_LCAR KC_2    // ľ
 #define SK_SCAR KC_3    // š
 #define SK_CCAR KC_4    // č
-#define SK_TACU KC_5    // ť
+#define SK_TCAR KC_5    // ť
 #define SK_ZCAR KC_6    // ž
 #define SK_YACU KC_7    // ý
 #define SK_AACU KC_8    // á
@@ -141,10 +141,10 @@
  */
 // Row 1
 #define SK_TILD ALGR(SK_PLUS) // ~
-#define SK_CIRC ALGR(SK_LACU) // ^ (dead)
+#define SK_CIRC ALGR(SK_LCAR) // ^ (dead)
 #define SK_BREV ALGR(SK_SCAR) // ˘ (dead)
 #define SK_RNGA ALGR(SK_CCAR) // ° (dead)
-#define SK_OGON ALGR(SK_TACU) // ˛ (dead)
+#define SK_OGON ALGR(SK_TCAR) // ˛ (dead)
 #define SK_GRV  ALGR(SK_ZCAR) // `
 #define SK_DOTA ALGR(SK_YACU) // ˙ (dead)
 #define SK_DACU ALGR(SK_EACU) // ˝ (dead)

I overlooked this when I was reviewing #8561. Even though the lowercase ľ and ť are written with what looks like an acute accent, it's actually a caron (mäkčeň).

@fauxpark
Copy link
Member Author

fauxpark commented Apr 1, 2020

Good spot

@drashna drashna merged commit 28a6a4a into qmk:master Apr 5, 2020
@fauxpark fauxpark deleted the keymap-extras-polish branch April 5, 2020 08:15
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Apr 10, 2020
* Add Polish keymap

* Fix wrong AltGr mapping

* These are ogoneks, not cedillas

* Too many !s

* ANSI

* Just use BSLS

* Move BSLS

* Move PIPE

* Fix some incorrect names in keymap_slovak.h

Thanks to vomindoraan
mrlinuxfish pushed a commit to mrlinuxfish/qmk_firmware that referenced this pull request Apr 12, 2020
* Add Polish keymap

* Fix wrong AltGr mapping

* These are ogoneks, not cedillas

* Too many !s

* ANSI

* Just use BSLS

* Move BSLS

* Move PIPE

* Fix some incorrect names in keymap_slovak.h

Thanks to vomindoraan
Quarren42 pushed a commit to Quarren42/qmk_firmware that referenced this pull request Apr 15, 2020
* Add Polish keymap

* Fix wrong AltGr mapping

* These are ogoneks, not cedillas

* Too many !s

* ANSI

* Just use BSLS

* Move BSLS

* Move PIPE

* Fix some incorrect names in keymap_slovak.h

Thanks to vomindoraan
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
* Add Polish keymap

* Fix wrong AltGr mapping

* These are ogoneks, not cedillas

* Too many !s

* ANSI

* Just use BSLS

* Move BSLS

* Move PIPE

* Fix some incorrect names in keymap_slovak.h

Thanks to vomindoraan
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
* Add Polish keymap

* Fix wrong AltGr mapping

* These are ogoneks, not cedillas

* Too many !s

* ANSI

* Just use BSLS

* Move BSLS

* Move PIPE

* Fix some incorrect names in keymap_slovak.h

Thanks to vomindoraan
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request May 24, 2020
* Add Polish keymap

* Fix wrong AltGr mapping

* These are ogoneks, not cedillas

* Too many !s

* ANSI

* Just use BSLS

* Move BSLS

* Move PIPE

* Fix some incorrect names in keymap_slovak.h

Thanks to vomindoraan
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
* Add Polish keymap

* Fix wrong AltGr mapping

* These are ogoneks, not cedillas

* Too many !s

* ANSI

* Just use BSLS

* Move BSLS

* Move PIPE

* Fix some incorrect names in keymap_slovak.h

Thanks to vomindoraan
nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Jun 11, 2020
* upstream/master: (312 commits)
  updated rules.mk and default keymap of Wonderland for VIA support (qmk#8668)
  Added Caps Lock LED handler to wilba.tech PCBs (qmk#8660)
  Add keyboard TGR-910 (qmk#8683)
  V-USB remote wakeup (qmk#7627)
  Add Greek keymap (qmk#8636)
  Add Polish keymap (qmk#8637)
  Add Korean keymap (qmk#8635)
  [Keyboard] Add 60_hhkb layout to hhkb (qmk#8618)
  [Keyboard] romeo - add via layout (qmk#8667)
  [Keyboard] Add ReverseStudio-DecadePad (qmk#8553)
  [Keyboard] Add bat43 Keyboard (qmk#8648)
  minor tweaks
  Fix saving output from avrdude and dfu-programmer
  Use version_arg in ESSENTIAL_BINARIES dict
  Fixes qmk#8541 by getting version from -dumpversion then --version as fallback
  VIA Support: 1upkeyboards Sweet16 (qmk#8652)
  [Keyboard] Lattice60 (qmk#8603)
  Discipline - Add ISO compatibility, rawHID enable, via layout (qmk#8627)
  [Keyboard] Add Orbit-X Keyboard (qmk#8605)
  add 60_tsangan_hhkb layout to GH60 rev. C (qmk#8617)
  ...
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jun 12, 2020
* Add Polish keymap

* Fix wrong AltGr mapping

* These are ogoneks, not cedillas

* Too many !s

* ANSI

* Just use BSLS

* Move BSLS

* Move PIPE

* Fix some incorrect names in keymap_slovak.h

Thanks to vomindoraan
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
* Add Polish keymap

* Fix wrong AltGr mapping

* These are ogoneks, not cedillas

* Too many !s

* ANSI

* Just use BSLS

* Move BSLS

* Move PIPE

* Fix some incorrect names in keymap_slovak.h

Thanks to vomindoraan
thorstenweber83 pushed a commit to thorstenweber83/qmk_firmware that referenced this pull request Sep 2, 2020
* Add Polish keymap

* Fix wrong AltGr mapping

* These are ogoneks, not cedillas

* Too many !s

* ANSI

* Just use BSLS

* Move BSLS

* Move PIPE

* Fix some incorrect names in keymap_slovak.h

Thanks to vomindoraan
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* Add Polish keymap

* Fix wrong AltGr mapping

* These are ogoneks, not cedillas

* Too many !s

* ANSI

* Just use BSLS

* Move BSLS

* Move PIPE

* Fix some incorrect names in keymap_slovak.h

Thanks to vomindoraan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants