fix: update test to make ci green

quadratic-funding · Mar 10, 2023 · 9b43243 · 9b43243
1 parent bff0567
commit 9b43243
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 9 deletions.
diff --git a/packages/actions/test/data/generators.ts b/packages/actions/test/data/generators.ts
@@ -153,6 +153,6 @@ export const generateFakeContribution = (
         verificationSoftware: fakeData.data.verificationSoftware,
         valid: fakeData.data.valid,
         lastUpdated: fakeData.data.lastUpdated,
-        beacon: fakeData.data.beacon
+        beacon: !fakeData.data.beacon ? undefined : fakeData.data.beacon
     }
 })
diff --git a/packages/actions/test/e2e/03-finalization.test.ts b/packages/actions/test/e2e/03-finalization.test.ts
@@ -179,8 +179,9 @@ describe("Finalization e2e", () => {
             const result = await checkAndPrepareCoordinatorForFinalization(userFunctions, ceremonyClosed.uid)
             expect(result).to.be.true
             // call the function
-            await expect(finalizeCircuit(userFunctions, ceremonyClosed.uid, finalizizationCircuit.uid, bucketName)).to
-                .be.fulfilled
+            await expect(
+                finalizeCircuit(userFunctions, ceremonyClosed.uid, finalizizationCircuit.uid, bucketName, `handle-id`)
+            ).to.be.fulfilled
 
             await expect(finalizeCeremony(userFunctions, ceremonyClosed.uid)).to.be.fulfilled
 

diff --git a/packages/actions/test/unit/contribute.test.ts b/packages/actions/test/unit/contribute.test.ts
@@ -925,6 +925,12 @@ describe("Contribute", () => {
                 fakeCeremoniesData.fakeCeremonyOpenedDynamic,
                 fakeCircuitsData.fakeCircuitSmallContributors
             )
+
+            // @todo need rework.
+            // delete when undefined.
+            if (!fakeContributions.fakeContributionDone.data.beacon)
+                delete fakeContributions.fakeContributionDone.data.beacon
+
             // user2 -> users[1]
             await createMockContribution(
                 adminFirestore,

diff --git a/packages/actions/test/unit/finalize.test.ts b/packages/actions/test/unit/finalize.test.ts
@@ -261,7 +261,8 @@ describe("Finalize", () => {
                         userFunctions,
                         fakeCeremoniesData.fakeCeremonyClosedDynamic.uid,
                         fakeCircuitsData.fakeCircuitSmallContributors.uid,
-                        bucketName
+                        bucketName,
+                        `handle-id`
                     )
                 ).to.be.rejectedWith("You do not have privileges to perform this operation.")
             })
@@ -272,7 +273,8 @@ describe("Finalize", () => {
                         userFunctions,
                         fakeCeremoniesData.fakeCeremonyClosedDynamic.uid,
                         fakeCircuitsData.fakeCircuitSmallContributors.uid,
-                        bucketName
+                        bucketName,
+                        `handle-id`
                     )
                 ).to.be.rejectedWith("You do not have privileges to perform this operation.")
             })
@@ -283,7 +285,8 @@ describe("Finalize", () => {
                         userFunctions,
                         "invalid",
                         fakeCircuitsData.fakeCircuitSmallContributors.uid,
-                        bucketName
+                        bucketName,
+                        `handle-id`
                     )
                 ).to.be.rejectedWith(
                     "Unable to find a document with the given identifier for the provided collection path."
@@ -295,7 +298,8 @@ describe("Finalize", () => {
                         userFunctions,
                         fakeCeremoniesData.fakeCeremonyClosedDynamic.uid,
                         "invalid",
-                        bucketName
+                        bucketName,
+                        `handle-id`
                     )
                 ).to.be.rejectedWith(
                     "Unable to find a document with the given identifier for the provided collection path."
@@ -307,7 +311,8 @@ describe("Finalize", () => {
                         userFunctions,
                         fakeCeremoniesData.fakeCeremonyClosedDynamic.uid,
                         fakeCircuitsData.fakeCircuitSmallContributors.uid,
-                        "invalidBucketName"
+                        "invalidBucketName",
+                        `handle-id`
                     )
                 ).to.be.rejectedWith("Unable to download the AWS S3 object from the provided ceremony bucket.")
             })
@@ -325,7 +330,8 @@ describe("Finalize", () => {
                         userFunctions,
                         fakeCeremoniesData.fakeCeremonyClosedDynamic.uid,
                         fakeCircuitsData.fakeCircuitSmallContributors.uid,
-                        bucketName
+                        bucketName,
+                        `handle-id`
                     )
                 ).to.be.fulfilled
             })