-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove qpe_hubbard tests #849
Conversation
unit tests to ensure round trip of each datatype using both numeric and sympy inputs.
Co-authored-by: Tanuj Khattar <tanujkhattar@google.com>
These tests are very large and will cause problems when running. These tests are now disabled.
Move the changes from bloq_finder.py to bloq_report_card.py. This way, only the serialization portion of the test is affected.
def test_whatever(bloq_autotester):
if bloq_autotester.check_name == 'serialization':
pytest.skip('too big')
bloq_autotester(_whatever_example) |
Rather than building on top of quantumlib#849, we keep the changes separate.
I gave this a try using test_qubitization_qpe_bloq_autotester as the "test_whatever" method. I noticed two issues with this:
It looks like this won't prevent this test from running.
|
|
Cleanup unneeded file
Gotcha. Should we address how to remove it in Also, it looks like only |
* Added methods to serialize and deserialize quantum data types. * Add serialization and deserialization methods for all data types. Write unit tests to ensure round trip of each datatype using both numeric and sympy inputs. * Update qualtran/protos/data_types.proto Co-authored-by: Tanuj Khattar <tanujkhattar@google.com> * Update Proto:wq * Fixed error formatting * Remove bitsize from QBit * Fixed formatting * Remove uncessesary files * Fix data type in formatted string in error message * Update qualtran/serialization/data_types_test.py * Added Sympy serialization. Sympy expressions can now be serialized through a recursive proto. * Clean up workspace * Remote large tests from get_bloq_examples() * Remove qpe_hubbard_model tests The qpe_hubbard_model is too large to test and causes developer friction. We have disabled the tests for now * Remove qpe_hubbard tests These tests are very large and will cause problems when running. These tests are now disabled. * Cleanup branch * Only remove the serialization tests from the large bloq.s Move the changes from bloq_finder.py to bloq_report_card.py. This way, only the serialization portion of the test is affected. * Address issues with failing sympy tests. Added support for fraction constant parameters. Fixed issue with cwap test assertion which expected sympy in the old string format. * Fix formatting * Fix formatting * Delete Untitled.ipynb Delete scratch notebook * Cleanup after merging local branches. (Old changes were accidentally left in). * Remove changes from PR#849 Rather than building on top of #849, we keep the changes separate. * Fixed assortment of bugs in fraction, and constant symbol serialization * Scratch test * Fixed bad reference to resolver dict by bloq module name. * Minor refactoring * Ran formatting tools * Cleanup forgotten test code. * Add tests, fix naming conventions, and add proper return types. * Update sympy_test.py Call sympy serialization directly rather than calling it through bloq. * Apply suggestions from code review Addressed nit comments. Co-authored-by: Tanuj Khattar <tanujkhattar@google.com> * Fix sympy_test * Fix return type of sympy_expr_from_proto --------- Co-authored-by: Tanuj Khattar <tanujkhattar@google.com>
I don't think these changes are needed any longer. We can close this PR. |
These tests are very large and will cause problems when running. These
tests are now disabled.