Remove unitary validation check when constructing GateWithRegisters.controlled()
#887
+40
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #885
For now, I've mainly copied the logic from
cirq.ControlledGate
to constructAbstractControlValues
object from parametersnum_controls
,control_values
andcontrol_qid_shape
but we should eventually get rid of these arguments or at least move this to a different place instead of onGateWithRegisters
. For example - we could add a newGWROperation
for cirq-style API and delegate to underlying gate'sgwr.controlled(ctrl_spec)
. Right now,cirq.GateOperation().controlled_by()
delegates togwr.controlled
but with the cirq-style API (num_control
,control_values
,control_qid_shape
).cc @anurudhp