Skip to content

Commit

Permalink
download node 18.18.0 LTS (#510)
Browse files Browse the repository at this point in the history
  • Loading branch information
shivam-sharma7 authored Sep 20, 2023
1 parent bb241d4 commit 47f42f0
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,15 @@ public class QuinoaPackageManagerInstallTest {
@RegisterExtension
static final QuarkusUnitTest config = QuinoaQuarkusUnitTest.create(NAME).toQuarkusUnitTest()
.overrideConfigKey("quarkus.quinoa.package-manager-install", "true")
.overrideConfigKey("quarkus.quinoa.package-manager-install.node-version", "18.17.0")
.overrideConfigKey("quarkus.quinoa.package-manager-install.node-version", "18.18.0")
.overrideConfigKey("quarkus.quinoa.package-manager-install.install-dir", INSTALL_DIR)
.assertLogRecords(l -> {
assertThat(l)
.anyMatch(s -> s.getMessage().equals("Running Quinoa package manager build command: %s") &&
((String) s.getParameters()[0])
.endsWith(computeBinary(INSTALL_DIR) + " run build"));
assertThat(l)
.anyMatch(s -> s.getMessage().equals("v18.17.0"));
.anyMatch(s -> s.getMessage().equals("v18.18.0"));
});

@Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ public class QuinoaPackageManagerInstallWithSpaceTest {
@RegisterExtension
static final QuarkusUnitTest config = QuinoaQuarkusUnitTest.create(NAME).toQuarkusUnitTest()
.overrideConfigKey("quarkus.quinoa.package-manager-install", "true")
.overrideConfigKey("quarkus.quinoa.package-manager-install.node-version", "18.17.0")
.overrideConfigKey("quarkus.quinoa.package-manager-install.node-version", "18.18.0")
.overrideConfigKey("quarkus.quinoa.package-manager-install.install-dir", INSTALL_DIR)
.assertLogRecords(l -> {
assertThat(l)
.anyMatch(s -> s.getMessage().equals("Running Quinoa package manager build command: %s") &&
((String) s.getParameters()[0])
.endsWith(computeBinary(INSTALL_DIR) + " run build"));
assertThat(l)
.anyMatch(s -> s.getMessage().equals("v18.17.0"));
.anyMatch(s -> s.getMessage().equals("v18.18.0"));
});

@Test
Expand Down
2 changes: 1 addition & 1 deletion docs/modules/ROOT/pages/index.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ Quinoa can be configured to install NodeJS and NPM in the project directory:
[source,properties]
----
quarkus.quinoa.package-manager-install=true <1>
quarkus.quinoa.package-manager-install.node-version=18.17.0 <2>
quarkus.quinoa.package-manager-install.node-version=18.18.0 <2>
----

<1> Enable package manager install
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
%angular.quarkus.quinoa.ignored-path-prefixes=/q,/bar/foo/baz
%angular.quarkus.quinoa.package-manager-install=true
%angular.quarkus.quinoa.package-manager-install.install-dir=target/
%angular.quarkus.quinoa.package-manager-install.node-version=18.17.0
%angular.quarkus.quinoa.package-manager-install.node-version=18.18.0
%lit.quarkus.quinoa.ui-dir=src/main/ui-lit
%lit.quarkus.quinoa.build-dir=dist
%lit.quarkus.quinoa.index-page=app.html
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ quarkus:
quinoa:
package-manager-install:
~: true
node-version: 18.17.0
node-version: 18.18.0

0 comments on commit 47f42f0

Please sign in to comment.