Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug: Fix DEBUG Statements #485

Closed
melloware opened this issue Aug 15, 2023 · 1 comment · Fixed by #487
Closed

Debug: Fix DEBUG Statements #485

melloware opened this issue Aug 15, 2023 · 1 comment · Fixed by #487
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@melloware
Copy link
Contributor

@shivam-sharma7 here is a good one for you. Find all isDebugEnabled and remove the wrapper.

So

            if (LOG.isDebugEnabled()) {
                LOG.debugf("Quinoa is re-routing SPA request '%s' to '/'", ctx.normalizedPath());
            }

Should just be:

 LOG.debugf("Quinoa is re-routing SPA request '%s' to '/'", ctx.normalizedPath());

The debugf part of the code internally already has the `isEnabled logic in it.

@melloware melloware added the enhancement New feature or request label Aug 15, 2023
@melloware melloware added this to the 2.1.0 milestone Aug 15, 2023
@ia3andy
Copy link
Collaborator

ia3andy commented Aug 16, 2023

@melloware the difference is more in evaluating the message string, but that's alright you can remove those

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants