Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly Snapshot failing with Angular Test #755

Closed
melloware opened this issue Sep 10, 2024 · 2 comments · Fixed by #757
Closed

Nightly Snapshot failing with Angular Test #755

melloware opened this issue Sep 10, 2024 · 2 comments · Fixed by #757
Assignees
@ia3andy
Labels
bug Something isn't working

Comments

@melloware
Copy link
Contributor

Describe the bug

Against latest nightly snapshot Quinoa is failing with.

[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.65 s -- in io.quarkiverse.quinoa.it.QuinoaCodestartTest
2024-09-10 06:50:40,688 INFO  [io.quarkus] (main) quarkus-quinoa-integration-tests stopped in 0.013s
[INFO] 
[INFO] Results:
[INFO] 
Error:  Failures: 
Error:    QuinoaUIAngularEsBuildTest.testHelloEndpoint:96 1 expectation failed.
Response body doesn't match expectation.
Expected: is "Hello Quinoa"
  Actual: <!doctype html>
<html lang="en" data-critters-container>
<head>
  <meta charset="utf-8">
  <title>QuinoaApp</title>
  <base href="/">
  <meta name="viewport" content="width=device-width, initial-scale=1">
  <link rel="icon" type="image/x-icon" href="favicon.ico">
<link rel="stylesheet" href="styles-5INURTSO.css"></head>
<body>
  <app-root></app-root>
<script src="polyfills-6EAL64PA.js" type="module"></script><script src="main-ZI56ITJ6.js" type="module"></script></body>
</html>


Error:    QuinoaUIAngularEsBuildTest.testUIIndex:47->checkUrl:67 expected: <Hello Quinoa> but was: <<!doctype html> <html lang="en" data-critters-container> <head> <meta charset="utf-8"> <title>QuinoaApp</title> <base href="/"> <meta name="viewport" content="width=device-width, initial-scale=1"> <link rel="icon" type="image/x-icon" href="favicon.ico"> <link rel="stylesheet" href="styles-5INURTSO.css"></head> <body> <app-root></app-root> <script src="polyfills-6EAL64PA.js" type="module"></script><script src="main-ZI56ITJ6.js" type="module"></script></body> </html>>
Error:    QuinoaUIAngularTest.testHelloEndpoint:96 1 expectation failed.
Response body doesn't match expectation.
Expected: is "Hello Quinoa"
  Actual: <!DOCTYPE html><html lang="en"><head>
  <meta charset="utf-8">
  <title>QuinoaApp</title>
  <base href="/">
  <meta name="viewport" content="width=device-width, initial-scale=1">
  <link rel="icon" type="image/x-icon" href="favicon.ico">
<link rel="stylesheet" href="styles.ef46db3751d8e999.css"></head>
<body>
  <app-root></app-root>
<script src="runtime.74c768d3725d01cd.js" type="module"></script><script src="polyfills.9778d3e5d4cbb198.js" type="module"></script><script src="main.90225e98234c3ba6.js" type="module"></script>

</body></html>

Error:    QuinoaUIAngularTest.testUIIndex:47->checkUrl:67 expected: <Hello Quinoa> but was: <<!DOCTYPE html><html lang="en"><head> <meta charset="utf-8"> <title>QuinoaApp</title> <base href="/"> <meta name="viewport" content="width=device-width, initial-scale=1"> <link rel="icon" type="image/x-icon" href="favicon.ico"> <link rel="stylesheet" href="styles.ef46db3751d8e999.css"></head> <body> <app-root></app-root> <script src="runtime.74c768d3725d01cd.js" type="module"></script><script src="polyfills.9778d3e5d4cbb198.js" type="module"></script><script src="main.90225e98234c3ba6.js" type="module"></script> </body></html>>
[INFO] 
Error:  Tests run: 27, Failures: 4, Errors: 0, Skipped: 0

so it looks like something big has changed that its serving the index.html instead of <Hello Quinoa>

Quinoa version

latest

Quarkus version

SNAPSHOT

Build / Runtime

Vite

Package Manager

NPM

Steps to reproduce the behavior

See nightly snapshot: https://github.com/quarkiverse/quarkus-quinoa/actions/runs/10786152361

Expected behavior

No response
@melloware melloware added the bug Something isn't working label Sep 10, 2024
@melloware
Copy link
Contributor Author

@ia3andy it definitely looks like Angular is failing and Vert.X is serving the index.html page instead of the expected result.

@melloware melloware changed the title Nightly Snapshot failing Nightly Snapshot failing with Angular Test Sep 13, 2024
@ia3andy
Copy link
Collaborator

ia3andy commented Sep 13, 2024

Here is the reason: https://github.com/quarkiverse/quarkus-quinoa/blob/main/integration-tests/src/main/resources/application.properties#L25

melloware added a commit to melloware/quarkus-quinoa that referenced this issue Sep 13, 2024
@melloware
Fix quarkiverse#755: Rename resteast-reactive to rest
3fd0fd2
@melloware melloware mentioned this issue Sep 13, 2024
Merged
melloware added a commit to melloware/quarkus-quinoa that referenced this issue Sep 13, 2024
@melloware
Fix quarkiverse#755: Rename resteasy-reactive to rest
3c8d9d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ia3andy ia3andy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #755: Rename resteasy-reactive to rest melloware/quarkus-quinoa
2 participants
@ia3andy @melloware