Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump quarkus #363

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Bump quarkus #363

merged 1 commit into from
Jun 2, 2023

Conversation

shivam-sharma7
Copy link
Member

Bump quarkus 3.1.0.final

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@melloware
Copy link
Contributor

I wasn't sure @ia3andy wanted to stay on 3.0.0 until there was a compelling reason to upgrade?

@melloware melloware requested a review from ia3andy May 31, 2023 16:56
@shivam-sharma7
Copy link
Member Author

I wasn't sure @ia3andy wanted to stay on 3.0.0 until there was a compelling reason to upgrade?

If this is so we can make it draft PR

@shivam-sharma7
Copy link
Member Author

shivam-sharma7 commented May 31, 2023

hey @melloware I need your help if you have some time then look at my Quarkus-CRUD project and help me to setup a CI/CD. I am getting error with existing one or you can open a patch for this.

@melloware
Copy link
Contributor

Yep try and add temurin like this..

 uses: actions/setup-java@v3
        with:
          distribution: 'temurin'
          java-version: 11

@shivam-sharma7
Copy link
Member Author

Yep try and add temurin like this..

 uses: actions/setup-java@v3
        with:
          distribution: 'temurin'
          java-version: 11

Thanks man :) ! here one more improvement for me java-version: 17

@melloware
Copy link
Contributor

OK i have confirmed this is OK to move to.

@melloware melloware merged commit d12089a into quarkiverse:main Jun 2, 2023
@shivam-sharma7 shivam-sharma7 deleted the patch-1 branch June 2, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants