Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solid Start support #396

Merged
merged 4 commits into from
Jun 28, 2023
Merged

Solid Start support #396

merged 4 commits into from
Jun 28, 2023

Conversation

shivam-sharma7
Copy link
Member

Describe your changes

Fixes Issue

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

Copy link
Contributor

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See feedback

@melloware
Copy link
Contributor

See PR: #398

@shivam-sharma7
Copy link
Member Author

See PR: #398

So, I need to remove letest changes?

@melloware
Copy link
Contributor

I think so I think you can drop this PR entirely since it will just all work out of the box when my PR is merged.

@ia3andy
Copy link
Collaborator

ia3andy commented Jun 26, 2023

Thanks @shivam-sharma7 this might be re-opened depending if we decide to add full vite config support or not.

@all-contributors please add @shivam-sharma7 for doc, data

@allcontributors
Copy link
Contributor

@ia3andy

I've put up a pull request to add @shivam-sharma7! 🎉

@ia3andy ia3andy reopened this Jun 28, 2023
@ia3andy ia3andy closed this Jun 28, 2023
@ia3andy
Copy link
Collaborator

ia3andy commented Jun 28, 2023

@shivam-sharma7 @melloware
I thought this was support for Solid Start which it seems we could add support for..

@melloware
Copy link
Contributor

melloware commented Jun 28, 2023

Yep I just ran their init and it generates this...

  "scripts": {
    "dev": "solid-start dev",
    "build": "solid-start build",
    "start": "solid-start start"
  },

It defaults to port 3000 so you can do this..

 SOLID_START("dist", "dev", 3000, Set.of("solid-start")),

Attached is the project:
solid-start.zip

@melloware melloware reopened this Jun 28, 2023
@melloware
Copy link
Contributor

I just made a commit to your branch

@ia3andy ia3andy changed the title SolidJS support Solid Start support Jun 28, 2023
Copy link
Collaborator

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We made it :) thanks team!

@melloware
Copy link
Contributor

good teamwork!

@melloware melloware merged commit 8f5d68f into quarkiverse:main Jun 28, 2023
@shivam-sharma7 shivam-sharma7 deleted the solidJs branch June 28, 2023 15:17
@apatrida
Copy link

This has changed since before 1.0.0 of Solid-Start and now uses vinxi to run the server processes. vinxi dev is the new dev mode. This needs an update for modern solid-start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants