-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solid Start support #396
Solid Start support #396
Conversation
deployment/src/main/java/io/quarkiverse/quinoa/deployment/packagemanager/FrameworkType.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See feedback
See PR: #398 |
So, I need to remove letest changes? |
I think so I think you can drop this PR entirely since it will just all work out of the box when my PR is merged. |
Thanks @shivam-sharma7 this might be re-opened depending if we decide to add full vite config support or not. @all-contributors please add @shivam-sharma7 for doc, data |
I've put up a pull request to add @shivam-sharma7! 🎉 |
deployment/src/main/java/io/quarkiverse/quinoa/deployment/packagemanager/FrameworkType.java
Outdated
Show resolved
Hide resolved
deployment/src/main/java/io/quarkiverse/quinoa/deployment/packagemanager/FrameworkType.java
Outdated
Show resolved
Hide resolved
@shivam-sharma7 @melloware |
Yep I just ran their init and it generates this... "scripts": {
"dev": "solid-start dev",
"build": "solid-start build",
"start": "solid-start start"
}, It defaults to port 3000 so you can do this.. SOLID_START("dist", "dev", 3000, Set.of("solid-start")), Attached is the project: |
I just made a commit to your branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We made it :) thanks team!
good teamwork! |
This has changed since before 1.0.0 of Solid-Start and now uses |
Describe your changes
Fixes Issue
Check List (Check all the applicable boxes)