From e13690be550a94cfacacb9094f3f459ee6812fc7 Mon Sep 17 00:00:00 2001 From: Rostislav Svoboda Date: Mon, 2 Sep 2024 13:09:33 +0200 Subject: [PATCH] Update reasoning for disabled tests in SpecialCharsTest --- .../quarkus/ts/startstop/SpecialCharsTest.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/testsuite/src/it/java/io/quarkus/ts/startstop/SpecialCharsTest.java b/testsuite/src/it/java/io/quarkus/ts/startstop/SpecialCharsTest.java index dae7a316..ed376974 100644 --- a/testsuite/src/it/java/io/quarkus/ts/startstop/SpecialCharsTest.java +++ b/testsuite/src/it/java/io/quarkus/ts/startstop/SpecialCharsTest.java @@ -183,14 +183,14 @@ public void specialJVM(TestInfo testInfo) throws IOException, InterruptedExcepti } @Test - @DisabledOnOs({OS.WINDOWS}) // https://github.com/quarkusio/quarkus/issues/9707 + @DisabledOnOs(value = {OS.WINDOWS}, disabledReason = "https://github.com/quarkusio/quarkus/issues/42942") public void specialDEV(TestInfo testInfo) throws IOException, InterruptedException { testRuntime(testInfo, Apps.JAKARTA_REST_MINIMAL, MvnCmds.DEV, ",;~!@#$%^&()"); } @Test @Tag("native") - @DisabledOnOs({OS.WINDOWS}) // https://github.com/quarkusio/quarkus/issues/9707 + @DisabledOnOs(value = {OS.WINDOWS}, disabledReason = "Native on Windows is not supported") @Disabled("TODO: https://github.com/quarkusio/quarkus/issues/42248") public void specialNative(TestInfo testInfo) throws IOException, InterruptedException { testRuntime(testInfo, Apps.JAKARTA_REST_MINIMAL, MvnCmds.NATIVE, ",;~!@#$%^&()"); @@ -202,14 +202,14 @@ public void diacriticsJVM(TestInfo testInfo) throws IOException, InterruptedExce } @Test - @DisabledOnOs({OS.WINDOWS}) // https://github.com/quarkusio/quarkus/issues/9707 + @DisabledOnOs(value = {OS.WINDOWS},disabledReason = "Needs env setup, https://github.com/quarkusio/quarkus/issues/9707 is fixed, tests pass on local Windows 10 with Czech language as default") public void diacriticsDEV(TestInfo testInfo) throws IOException, InterruptedException { testRuntime(testInfo, Apps.JAKARTA_REST_MINIMAL, MvnCmds.DEV, "ěščřžýáíéůú"); } @Test @Tag("native") - @DisabledOnOs({OS.WINDOWS}) // https://github.com/quarkusio/quarkus/issues/9707 + @DisabledOnOs(value = {OS.WINDOWS}, disabledReason = "Native on Windows is not supported") public void diacriticsNative(TestInfo testInfo) throws IOException, InterruptedException { testRuntime(testInfo, Apps.JAKARTA_REST_MINIMAL, MvnCmds.NATIVE, "ěščřžýáíéůú"); } @@ -220,14 +220,14 @@ public void japaneseJVM(TestInfo testInfo) throws IOException, InterruptedExcept } @Test - @DisabledOnOs({OS.WINDOWS}) // https://github.com/quarkusio/quarkus/issues/9707 + @DisabledOnOs(value = {OS.WINDOWS},disabledReason = "Needs env setup, https://github.com/quarkusio/quarkus/issues/9707 is fixed, tests pass on local Windows 10 with Czech language as default") public void japaneseDEV(TestInfo testInfo) throws IOException, InterruptedException { testRuntime(testInfo, Apps.JAKARTA_REST_MINIMAL, MvnCmds.DEV, "元気かい"); } @Test @Tag("native") - @DisabledOnOs({OS.WINDOWS}) // https://github.com/quarkusio/quarkus/issues/9707 + @DisabledOnOs(value = {OS.WINDOWS}, disabledReason = "Native on Windows is not supported") public void japaneseNative(TestInfo testInfo) throws IOException, InterruptedException { testRuntime(testInfo, Apps.JAKARTA_REST_MINIMAL, MvnCmds.NATIVE, "元気かい"); } @@ -238,14 +238,14 @@ public void otherJVM(TestInfo testInfo) throws IOException, InterruptedException } @Test - @DisabledOnOs({OS.WINDOWS}) // https://github.com/quarkusio/quarkus/issues/9707 + @DisabledOnOs(value = {OS.WINDOWS},disabledReason = "Needs env setup, https://github.com/quarkusio/quarkus/issues/9707 is fixed, tests pass on local Windows 10 with Czech language as default") public void otherDEV(TestInfo testInfo) throws IOException, InterruptedException { testRuntime(testInfo, Apps.JAKARTA_REST_MINIMAL, MvnCmds.DEV, "Îñţérñåţîöñåļîžåţîờñ"); } @Test @Tag("native") - @DisabledOnOs({OS.WINDOWS}) // https://github.com/quarkusio/quarkus/issues/9707 + @DisabledOnOs(value = {OS.WINDOWS}, disabledReason = "Native on Windows is not supported") public void otherNative(TestInfo testInfo) throws IOException, InterruptedException { testRuntime(testInfo, Apps.JAKARTA_REST_MINIMAL, MvnCmds.NATIVE, "Îñţérñåţîöñåļîžåţîờñ"); }